Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2677013002: Remove obsolete WebString comment from string_util (Closed)

Created:
3 years, 10 months ago by Adam Rice
Modified:
3 years, 10 months ago
Reviewers:
kinuko, Mark Mentovai
CC:
chromium-reviews, jshin+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete WebString comment from string_util string_util.h contained the following comment: // A convenience adaptor for WebStrings, as they don't convert into // StringPieces directly. prior to the string16 overload of IsStringASCII(). Since r447320 the implicit conversion from WebString to string16 has been removed so this doesn't work. WebString::containsOnlyASCII() should be used instead. BUG=667131 Review-Url: https://codereview.chromium.org/2677013002 Cr-Commit-Position: refs/heads/master@{#448471} Committed: https://chromium.googlesource.com/chromium/src/+/3db94dc4cd5cc78b799faac1040d843019a9fb9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M base/strings/string_util.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Adam Rice
Let me know if you already have a CL in flight to do this and ...
3 years, 10 months ago (2017-02-06 03:59:17 UTC) #2
kinuko
lgtm!
3 years, 10 months ago (2017-02-06 20:50:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677013002/1
3 years, 10 months ago (2017-02-06 22:13:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/357889)
3 years, 10 months ago (2017-02-06 22:22:44 UTC) #7
Adam Rice
+mark for //base OWNERS.
3 years, 10 months ago (2017-02-06 22:28:17 UTC) #9
Mark Mentovai
LGTM
3 years, 10 months ago (2017-02-06 22:34:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677013002/1
3 years, 10 months ago (2017-02-06 22:41:19 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 00:46:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3db94dc4cd5cc78b799faac1040d...

Powered by Google App Engine
This is Rietveld 408576698