Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2676973003: [cleanup] Remove some WebPermissionType which are unused. (Closed)

Created:
3 years, 10 months ago by riju_
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cleanup] Remove some WebPermissionType which are unused. Only 3 WebPermissionType types are used for implementing permission delegation. (https://bugs.chromium.org/p/chromium/issues/detail?id=614608) The rest can be removed. BUG=none Review-Url: https://codereview.chromium.org/2676973003 Cr-Commit-Position: refs/heads/master@{#448996} Committed: https://chromium.googlesource.com/chromium/src/+/21c93b0db86d1d7aa881a7f08778c6f20a935406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/public/platform/modules/permissions/WebPermissionType.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
riju_
@mounir: PTAL.
3 years, 10 months ago (2017-02-06 12:12:25 UTC) #6
mlamouri (slow - plz ping)
Thanks for the CL. At the moment, WebPermissionType is mirroring the Mojo permission types. Is ...
3 years, 10 months ago (2017-02-07 12:30:12 UTC) #7
riju_
On 2017/02/07 12:30:12, mlamouri wrote: > Thanks for the CL. At the moment, WebPermissionType is ...
3 years, 10 months ago (2017-02-07 12:48:11 UTC) #8
mlamouri (slow - plz ping)
Thanks for the context. lgtm but I think it would be better to use the ...
3 years, 10 months ago (2017-02-08 12:25:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676973003/1
3 years, 10 months ago (2017-02-08 12:30:53 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 15:09:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21c93b0db86d1d7aa881a7f08778...

Powered by Google App Engine
This is Rietveld 408576698