Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2676903002: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, zea+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, agrieve+watch_chromium.org, jam, abarth-chromium, haraken, dglazkov+blink, darin-cc_chromium.org, mac-reviews_chromium.org, blink-reviews, blink-reviews-api_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TEAM/COMPONENT BUG=679905 Review-Url: https://codereview.chromium.org/2676903002 Cr-Commit-Position: refs/heads/master@{#448843} Committed: https://chromium.googlesource.com/chromium/src/+/0d21d6aa2404e45d9bc1d12afeec9bedc8114bbf

Patch Set 1 #

Total comments: 16

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/services/gcm/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/budget_service/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/gcm/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/gcm_driver/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/budget/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/budget_service/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-03 22:32:05 UTC) #2
Peter Beverloo
Thanks for doing this! lgtm w/ suggestions https://codereview.chromium.org/2676903002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/services/gcm/OWNERS (right): https://codereview.chromium.org/2676903002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/OWNERS#newcode4 chrome/android/java/src/org/chromium/chrome/browser/services/gcm/OWNERS:4: # COMPONENT: ...
3 years, 10 months ago (2017-02-07 17:16:54 UTC) #3
ymzhang1
https://codereview.chromium.org/2676903002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/services/gcm/OWNERS (right): https://codereview.chromium.org/2676903002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/OWNERS#newcode4 chrome/android/java/src/org/chromium/chrome/browser/services/gcm/OWNERS:4: # COMPONENT: UI>Browser On 2017/02/07 17:16:54, Peter Beverloo wrote: ...
3 years, 10 months ago (2017-02-07 17:50:24 UTC) #4
ymzhang1
On 2017/02/07 17:16:54, Peter Beverloo wrote: > Thanks for doing this! lgtm w/ suggestions > ...
3 years, 10 months ago (2017-02-07 17:51:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676903002/20001
3 years, 10 months ago (2017-02-08 00:23:24 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 01:44:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d21d6aa2404e45d9bc1d12afeec...

Powered by Google App Engine
This is Rietveld 408576698