Add helper methods for skipping Dart VM native bodies.

Add helper methods for skipping Dart VM native bodies.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/34a0d345f5635c17d93541cf5bb1198bfa3a7c0b

[ahe, 2017-02-03 14:29:35]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2017-02-03 17:18:53]

lgtm

nice comments BTW. minor optional suggestion below.

https://codereview.chromium.org/2676813002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart (right):

https://codereview.chromium.org/2676813002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart:7: ///     native STRING
consider adding one more sentence saying that this is in a separate file because
parser.dart is spec compliant and this is not part of the spec syntax?

[ahe, 2017-02-03 17:26:42]

Thank you, Siggi. I like your suggestion.

https://codereview.chromium.org/2676813002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart (right):

https://codereview.chromium.org/2676813002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart:1: // Copyright (c) 2012,
the Dart project authors.  Please see the AUTHORS file
It's 2017.

https://codereview.chromium.org/2676813002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart:2: // for details. All
rights reserved. Use of this source code is governed by a
Add note to listener events about these helper methods.

[ahe, 2017-02-06 10:17:54]

Thank you, new patch set uploaded. Committing now.

https://codereview.chromium.org/2676813002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart (right):

https://codereview.chromium.org/2676813002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart:1: // Copyright (c) 2012,
the Dart project authors.  Please see the AUTHORS file
On 2017/02/03 17:26:42, ahe wrote:
> It's 2017.

Done.

https://codereview.chromium.org/2676813002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart:2: // for details. All
rights reserved. Use of this source code is governed by a
On 2017/02/03 17:26:42, ahe wrote:
> Add note to listener events about these helper methods.

Done.

https://codereview.chromium.org/2676813002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart:7: ///     native STRING
On 2017/02/03 17:18:52, Siggi Cherem (dart-lang) wrote:
> consider adding one more sentence saying that this is in a separate file
because
> parser.dart is spec compliant and this is not part of the spec syntax?

Done.

[ahe, 2017-02-06 10:18:07]

Description was changed from

==========
Add helper methods for skipping Dart VM native bodies.
==========

to

==========
Add helper methods for skipping Dart VM native bodies.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/34a0d345f5635c17d93541cf5bb1198bfa3a7c0b
==========

[ahe, 2017-02-06 10:18:08]

Committed patchset #2 (id:20001) manually as
34a0d345f5635c17d93541cf5bb1198bfa3a7c0b (presubmit successful).