Add handleMemberName event to allow parsing Dart VM natives.

Add handleMemberName event to allow parsing Dart VM natives.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/6b3c11089752fe4cef59fd748ea7e075e8983b52

[ahe, 2017-02-03 14:23:34]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[ahe, 2017-02-03 14:23:35]

The problem, parse:

  int get length native "List_getLength";

The solution: allow the listener to rewrite the list returned from
findMemberName (my next CL will use this, if you want examples).

Alternative: implement handling of native syntax in parser.dart. We avoided
doing that in dart2js as we didn't want to extend the parser with unspecified
syntax, and I'd like to keep it that way.

[Siggi Cherem (dart-lang), 2017-02-03 17:15:51]

lgtm

I think I'm missing some of the picture though - it seems like you'd be just
dropping that native annotation when you are done parsing, is that correct? How
does the VM read in that name to bind the native code? Is it attached to the
kernel AST somewhere?

We converted all of these kind of bindings in dart2js to annotations, I wonder
if that's a route we could take with the VM patches as well and get rid of the
unspecified syntax. If not, maybe it should be specified and supported?

https://codereview.chromium.org/2671013002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/listener.dart (right):

https://codereview.chromium.org/2671013002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/listener.dart:409: Link<Token>
handleMemberName(Link<Token> identifiers) => identifiers;
consider a short dartdoc to indicate that most listeners don't need to override
this, but that vm parser do to filter out the stuff after native?

[ahe, 2017-02-03 17:24:30]

On 2017/02/03 17:15:51, Siggi Cherem (dart-lang) wrote:
> I think I'm missing some of the picture though - it seems like you'd be just
> dropping that native annotation when you are done parsing, is that correct?
How
> does the VM read in that name to bind the native code? Is it attached to the
> kernel AST somewhere?

I'm not yet attaching the information. I'm working on that.

> We converted all of these kind of bindings in dart2js to annotations, I wonder
> if that's a route we could take with the VM patches as well and get rid of the
> unspecified syntax. If not, maybe it should be specified and supported?

I think that will be easier once the VM stops reading sources. Short term, I
think this is the best solution (another factor here is that I haven't
implemented annotations yet).
 
It should be really easy to switch to annotations when kernel is the only source
for the VM, because dartk already translates Dart VM natives to annotations.

>
https://codereview.chromium.org/2671013002/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/parser/listener.dart:409: Link<Token>
> handleMemberName(Link<Token> identifiers) => identifiers;
> consider a short dartdoc to indicate that most listeners don't need to
override
> this, but that vm parser do to filter out the stuff after native?

Good point. I'll add this to CL 2676813002 (as I can also refer to the helper
methods).

[ahe, 2017-02-06 10:11:19]

Description was changed from

==========
Add handleMemberName event to allow parsing Dart VM natives.
==========

to

==========
Add handleMemberName event to allow parsing Dart VM natives.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6b3c11089752fe4cef59fd748ea7e075e8983b52
==========

[ahe, 2017-02-06 10:11:21]

Committed patchset #1 (id:1) manually as
6b3c11089752fe4cef59fd748ea7e075e8983b52 (presubmit successful).