MD Settings: Put fingerprints on its own subpage.

MD Settings: Put fingerprints on its own subpage.

The fingerprint list was previously part of the lock screen subpage. This CL moves it to its own subpage.

BUG=672269
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2676763002
Cr-Commit-Position: refs/heads/master@{#448068}
Committed: https://chromium.googlesource.com/chromium/src/+/7eaad7f3264466763400ab8ea49b27af566ffa1a

[sammiequon, 2017-02-03 01:35:27]

Description was changed from

==========
MD Settings: Put fingerprints on its own subpage.

The fingerprint list was previously part of the lock screen subpage. This CL
moves it to its own subpage.

BUG=672269
TEST=none
==========

to

==========
MD Settings: Put fingerprints on its own subpage.

The fingerprint list was previously part of the lock screen subpage. This CL
moves it to its own subpage.

BUG=672269
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-02-03 01:35:32]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 01:36:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 01:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:47:12]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[sammiequon, 2017-02-03 16:29:30]

Patchset #1 (id:1) has been deleted

[sammiequon, 2017-02-03 16:29:36]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 16:29:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 17:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 17:46:23]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2017-02-03 17:48:13]

Description was changed from

==========
MD Settings: Put fingerprints on its own subpage.

The fingerprint list was previously part of the lock screen subpage. This CL
moves it to its own subpage.

BUG=672269
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Put fingerprints on its own subpage.

The fingerprint list was previously part of the lock screen subpage. This CL
moves it to its own subpage.

BUG=672269
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-02-03 17:48:13]

sammiequon@chromium.org changed reviewers:
+ stevenjb@chromium.org

[sammiequon, 2017-02-03 17:48:34]

On 2017/02/03 17:48:13, sammiequon wrote:
> mailto:sammiequon@chromium.org changed reviewers:
> + mailto:stevenjb@chromium.org

stevenjb@ - Please take a look. Thanks!

[stevenjb, 2017-02-03 18:10:13]

https://codereview.chromium.org/2676763002/diff/20001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2676763002/diff/20001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:2142: <message
name="IDS_SETTINGS_PEOPLE_LOCK_SCREEN_EDIT_FINGERPRINTS_SUBLABEL"
desc="Secondary text on the lock screen which opens up the fingerprint
subpage.">
nit: _DESCRIPTION

https://codereview.chromium.org/2676763002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/2676763002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/browser_options_handler.cc:531:
IDS_SETTINGS_PEOPLE_LOCK_SCREEN_EDIT_FINGERPRINTS_SUBLABEL},
These strings are for the old "options" UI, you need to put these in
md_settings_localized_strings_provider.cc instead.

also, nit: Use Fingerprints, FingerprintsDescription and
FINGERPRINTS_DESCRIPTION

[sammiequon, 2017-02-03 18:52:54]

https://codereview.chromium.org/2676763002/diff/20001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2676763002/diff/20001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:2142: <message
name="IDS_SETTINGS_PEOPLE_LOCK_SCREEN_EDIT_FINGERPRINTS_SUBLABEL"
desc="Secondary text on the lock screen which opens up the fingerprint
subpage.">
On 2017/02/03 18:10:13, stevenjb wrote:
> nit: _DESCRIPTION

Done.

https://codereview.chromium.org/2676763002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/2676763002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/browser_options_handler.cc:531:
IDS_SETTINGS_PEOPLE_LOCK_SCREEN_EDIT_FINGERPRINTS_SUBLABEL},
On 2017/02/03 18:10:13, stevenjb wrote:
> These strings are for the old "options" UI, you need to put these in
> md_settings_localized_strings_provider.cc instead.
> 
> also, nit: Use Fingerprints, FingerprintsDescription and
> FINGERPRINTS_DESCRIPTION

I added to md_settings_localized_strings_provider.cc below. Since this is part
of lock_screen.html which is part of both settings & options, we will need it
here too as well right? Done nit.

[stevenjb, 2017-02-03 18:56:17]

lgtm

https://codereview.chromium.org/2676763002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/2676763002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/browser_options_handler.cc:531:
IDS_SETTINGS_PEOPLE_LOCK_SCREEN_EDIT_FINGERPRINTS_SUBLABEL},
On 2017/02/03 18:52:54, sammiequon wrote:
> On 2017/02/03 18:10:13, stevenjb wrote:
> > These strings are for the old "options" UI, you need to put these in
> > md_settings_localized_strings_provider.cc instead.
> > 
> > also, nit: Use Fingerprints, FingerprintsDescription and
> > FINGERPRINTS_DESCRIPTION
> 
> I added to md_settings_localized_strings_provider.cc below. Since this is part
> of lock_screen.html which is part of both settings & options, we will need it
> here too as well right? Done nit.

Ah, OK, I didn't realize this was also embedded in the old options, that is
correct, and somehow I missed the md_settings_localized_strings_provider.cc
changes, sorry.

[sammiequon, 2017-02-03 19:24:17]

On 2017/02/03 18:10:13, stevenjb wrote:
>
https://codereview.chromium.org/2676763002/diff/20001/chrome/app/settings_str...
> File chrome/app/settings_strings.grdp (right):
> 
>
https://codereview.chromium.org/2676763002/diff/20001/chrome/app/settings_str...
> chrome/app/settings_strings.grdp:2142: <message
> name="IDS_SETTINGS_PEOPLE_LOCK_SCREEN_EDIT_FINGERPRINTS_SUBLABEL"
> desc="Secondary text on the lock screen which opens up the fingerprint
> subpage.">
> nit: _DESCRIPTION
> 
>
https://codereview.chromium.org/2676763002/diff/20001/chrome/browser/ui/webui...
> File chrome/browser/ui/webui/options/browser_options_handler.cc (right):
> 
>
https://codereview.chromium.org/2676763002/diff/20001/chrome/browser/ui/webui...
> chrome/browser/ui/webui/options/browser_options_handler.cc:531:
> IDS_SETTINGS_PEOPLE_LOCK_SCREEN_EDIT_FINGERPRINTS_SUBLABEL},
> These strings are for the old "options" UI, you need to put these in
> md_settings_localized_strings_provider.cc instead.
> 
> also, nit: Use Fingerprints, FingerprintsDescription and
> FINGERPRINTS_DESCRIPTION

Thanks!

[sammiequon, 2017-02-03 19:24:23]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-02-03 19:24:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 20:50:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486149863934300,
"parent_rev": "d8f04daf8b30d368349191fc0522e05c1dc32a98", "commit_rev":
"7eaad7f3264466763400ab8ea49b27af566ffa1a"}

[commit-bot: I haz the power, 2017-02-03 20:51:02]

Description was changed from

==========
MD Settings: Put fingerprints on its own subpage.

The fingerprint list was previously part of the lock screen subpage. This CL
moves it to its own subpage.

BUG=672269
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Put fingerprints on its own subpage.

The fingerprint list was previously part of the lock screen subpage. This CL
moves it to its own subpage.

BUG=672269
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2676763002
Cr-Commit-Position: refs/heads/master@{#448068}
Committed:
https://chromium.googlesource.com/chromium/src/+/7eaad7f3264466763400ab8ea49b...
==========

[commit-bot: I haz the power, 2017-02-03 20:51:03]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7eaad7f3264466763400ab8ea49b...