Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2676743003: MD Settings: Hide sections in guest mode (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Hide sections in guest mode BUG=682107 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2676743003 Cr-Commit-Position: refs/heads/master@{#448151} Committed: https://chromium.googlesource.com/chromium/src/+/891c2c575f1da67a3e5886d536e671ef11142ae9

Patch Set 1 #

Patch Set 2 : Fix closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -21 lines) Patch
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 chunk +10 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.js View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html View 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/device_page/storage.html View 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/device_page/storage.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
stevenjb
3 years, 10 months ago (2017-02-03 20:01:03 UTC) #3
hcarmona
lgtm
3 years, 10 months ago (2017-02-03 20:20:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676743003/1
3 years, 10 months ago (2017-02-03 22:35:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/5976)
3 years, 10 months ago (2017-02-03 22:59:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676743003/20001
3 years, 10 months ago (2017-02-04 00:50:02 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 02:36:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/891c2c575f1da67a3e5886d536e6...

Powered by Google App Engine
This is Rietveld 408576698