Upstream foreign fetch tests.

Upstream foreign fetch tests.

BUG=678498
BUG=688116
Review-Url: https://codereview.chromium.org/2676733002
Cr-Commit-Position: refs/heads/master@{#450134}
Committed: https://chromium.googlesource.com/chromium/src/+/e09a722158af5e49f59381a50669a30003f3bbb5

[Marijn Kruisselbrink, 2017-02-02 23:22:56]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 23:23:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-03 00:12:21]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 00:12:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 01:42:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:42:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Marijn Kruisselbrink, 2017-02-03 18:10:46]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 18:11:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 19:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 19:15:28]

Dry run: This issue passed the CQ dry run.

[Marijn Kruisselbrink, 2017-02-03 21:39:33]

Description was changed from

==========
WIP Upstream foreign fetch tests.

BUG=678498
BUG=688116
==========

to

==========
Upstream foreign fetch tests.

BUG=678498
BUG=688116
==========

[Marijn Kruisselbrink, 2017-02-03 21:47:00]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 21:47:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 23:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 23:16:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Marijn Kruisselbrink, 2017-02-03 23:19:18]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[Marijn Kruisselbrink, 2017-02-03 23:19:26]

Patchset #4 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-02-03 23:19:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-04 00:14:34]

mek@chromium.org changed reviewers:
+ falken@chromium.org

[Marijn Kruisselbrink, 2017-02-04 00:14:35]

Before actually landing this https://github.com/w3c/ServiceWorker/pull/1067
needs to be resolved (and if that gets resolved by not landing the spec change,
I'll have to update this CL to not include the tests for that behavior).

Also not entirely sure which change in here made
service-worker-csp-script.https.html suddenly pass... Probably the
fetch-access-control.py bugfix, but I didn't look too deeply into that...

[commit-bot: I haz the power, 2017-02-04 00:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 00:22:59]

Dry run: This issue passed the CQ dry run.

[falken, 2017-02-07 02:10:47]

lgtm

https://codereview.chromium.org/2676733002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/foreign-fetch-helpers.js
(right):

https://codereview.chromium.org/2676733002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/foreign-fetch-helpers.js:4:
// are resolved relative to the /serviceworker/resources/ directory on a
nit: /service-workers/service-worker/resources/ directory?

https://codereview.chromium.org/2676733002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/foreign-fetch-helpers.js:10:
var channel = new MessageChannel();
nit: let or const for consistency with fetch_from_different_origin

https://codereview.chromium.org/2676733002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/foreign-fetch-helpers.js:13:
port: channel.port1},
nit: Is it possible to remove the port property? I think the other side just
gets event.ports[0] directly.

Also, is it possible to just use event.source instead of creating the
MessageChannel? I find MessageChannel to be so verbose and confusing so avoid it
if possible.

https://codereview.chromium.org/2676733002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/foreign-fetch-helpers.js:36:
let channel = new MessageChannel();
const?

[qyearsley, 2017-02-07 18:33:20]

qyearsley@chromium.org changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2017-02-07 18:33:21]

Just wanted to jump in real quick here and say thanks for doing this! :-)

[Marijn Kruisselbrink, 2017-02-07 21:31:58]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 21:34:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 23:01:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 23:01:04]

Dry run: This issue passed the CQ dry run.

[Marijn Kruisselbrink, 2017-02-13 21:55:08]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 21:56:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-13 22:00:26]

https://codereview.chromium.org/2676733002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/foreign-fetch-helpers.js
(right):

https://codereview.chromium.org/2676733002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/foreign-fetch-helpers.js:4:
// are resolved relative to the /serviceworker/resources/ directory on a
On 2017/02/07 at 02:10:47, falken wrote:
> nit: /service-workers/service-worker/resources/ directory?

Done

https://codereview.chromium.org/2676733002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/foreign-fetch-helpers.js:13:
port: channel.port1},
On 2017/02/07 at 02:10:47, falken wrote:
> nit: Is it possible to remove the port property? I think the other side just
gets event.ports[0] directly.
> 
> Also, is it possible to just use event.source instead of creating the
MessageChannel? I find MessageChannel to be so verbose and confusing so avoid it
if possible.

Yeah, here using event.source directly would indeed work. I often find trying to
use the window global onmessage for replies to be pretty verbose and confusing
(and easy to get wrong), due to all messages from all nested frames, parent
frames and other windows all arriving to the same event listeners. But here it's
not too tricky to work around all that.

https://codereview.chromium.org/2676733002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/foreign-fetch-helpers.js:36:
let channel = new MessageChannel();
On 2017/02/07 at 02:10:47, falken wrote:
> const?

Done

[Marijn Kruisselbrink, 2017-02-13 22:51:16]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-13 22:51:22]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-13 22:51:22]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2676733002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-13 22:52:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 22:59:33]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487026282367840,
"parent_rev": "95ca8e045eb12df12283d61f68caba1971ff0bff", "commit_rev":
"e09a722158af5e49f59381a50669a30003f3bbb5"}

[commit-bot: I haz the power, 2017-02-13 23:00:12]

Description was changed from

==========
Upstream foreign fetch tests.

BUG=678498
BUG=688116
==========

to

==========
Upstream foreign fetch tests.

BUG=678498
BUG=688116

Review-Url: https://codereview.chromium.org/2676733002
Cr-Commit-Position: refs/heads/master@{#450134}
Committed:
https://chromium.googlesource.com/chromium/src/+/e09a722158af5e49f59381a50669...
==========

[commit-bot: I haz the power, 2017-02-13 23:00:14]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/e09a722158af5e49f59381a50669...