Convert ChannelSplitter test to testharness

Convert ChannelSplitter test to testharness

Update test to use testharness and new Audit.  This was updated
manually, and slightly refactored into two separate tests.

BUG=688011
TEST=audiochannelsplitter.html

Review-Url: https://codereview.chromium.org/2676683002
Cr-Commit-Position: refs/heads/master@{#447848}
Committed: https://chromium.googlesource.com/chromium/src/+/537181f43f30baf668b1fd2a52893b789ada2198

[Raymond Toy, 2017-02-02 16:52:33]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-02 16:52:34]

PTAL.

I'll reindent after you review these basic changes.

[Raymond Toy, 2017-02-02 16:53:30]

https://codereview.chromium.org/2676683002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ChannelSplitter/audiochannelsplitter.html
(right):

https://codereview.chromium.org/2676683002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ChannelSplitter/audiochannelsplitter.html:106:
'splitternode.toString().indexOf("ChannelSplitterNode")')
Can you suggest a better description for this test?

[hongchan, 2017-02-02 19:48:17]

lgtm with nit: consider removing a redundant assertion.

https://codereview.chromium.org/2676683002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ChannelSplitter/audiochannelsplitter.html
(right):

https://codereview.chromium.org/2676683002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ChannelSplitter/audiochannelsplitter.html:20:
//description("Tests AudioChannelSplitter.");
This needs to be gone.

https://codereview.chromium.org/2676683002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ChannelSplitter/audiochannelsplitter.html:106:
'splitternode.toString().indexOf("ChannelSplitterNode")')
On 2017/02/02 16:53:30, Raymond Toy wrote:
> Can you suggest a better description for this test?

Actually I am not sure what this is trying to test. I think we should remove
this in another CL.

[Raymond Toy, 2017-02-02 20:03:56]

https://codereview.chromium.org/2676683002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ChannelSplitter/audiochannelsplitter.html
(right):

https://codereview.chromium.org/2676683002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ChannelSplitter/audiochannelsplitter.html:20:
//description("Tests AudioChannelSplitter.");
On 2017/02/02 19:48:16, hongchan wrote:
> This needs to be gone.

Done.

https://codereview.chromium.org/2676683002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ChannelSplitter/audiochannelsplitter.html:106:
'splitternode.toString().indexOf("ChannelSplitterNode")')
On 2017/02/02 19:48:16, hongchan wrote:
> On 2017/02/02 16:53:30, Raymond Toy wrote:
> > Can you suggest a better description for this test?
> 
> Actually I am not sure what this is trying to test. I think we should remove
> this in another CL.

Let's remove it now.

[Raymond Toy, 2017-02-02 20:04:17]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-02-02 20:04:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2676683002/#ps20001
(title: "Address review comments.")

[commit-bot: I haz the power, 2017-02-02 20:04:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 21:30:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486065857147350,
"parent_rev": "a21f7225d107eb402268782a30f32ee3813feed5", "commit_rev":
"537181f43f30baf668b1fd2a52893b789ada2198"}

[commit-bot: I haz the power, 2017-02-02 21:31:00]

Description was changed from

==========
Convert ChannelSplitter test to testharness

Update test to use testharness and new Audit.  This was updated
manually, and slightly refactored into two separate tests.

BUG=688011
TEST=audiochannelsplitter.html
==========

to

==========
Convert ChannelSplitter test to testharness

Update test to use testharness and new Audit.  This was updated
manually, and slightly refactored into two separate tests.

BUG=688011
TEST=audiochannelsplitter.html

Review-Url: https://codereview.chromium.org/2676683002
Cr-Commit-Position: refs/heads/master@{#447848}
Committed:
https://chromium.googlesource.com/chromium/src/+/537181f43f30baf668b1fd2a5289...
==========

[commit-bot: I haz the power, 2017-02-02 21:31:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/537181f43f30baf668b1fd2a5289...