Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2676673006: Reland of Simplify the initialization of Git objects in Host. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
lushnikov, jeffcarp
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Simplify the initialization of Git objects in Host. (patchset #1 id:1 of https://codereview.chromium.org/2671583002/ ) Reason for revert: Reverting speculative revert; the flaky failure on Mac was unrelated to this CL. Original issue's description: > Revert of Simplify the initialization of Git objects in Host. (patchset #3 id:40001 of https://codereview.chromium.org/2663623003/ ) > > Reason for revert: > Speculative revert. This might be the cause of build flakiness, see crbug.com/687707 > > Original issue's description: > > Simplify the initialization of Git objects in Host. > > > > This CL makes calling Host.initialize_scm() unnecessary by making > > it so that the Git object is initialized when required. It also > > merges scm() and scm_for_path(), and moves initialization logic > > into the Git class. > > > > BUG=676012 > > > > Review-Url: https://codereview.chromium.org/2663623003 > > Cr-Commit-Position: refs/heads/master@{#447582} > > Committed: https://chromium.googlesource.com/chromium/src/+/7091f37e5b763d57e4752a4e69cf46719b8ea1c4 > > TBR=jeffcarp@chromium.org,qyearsley@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=676012 > > Review-Url: https://codereview.chromium.org/2671583002 > Cr-Commit-Position: refs/heads/master@{#447650} > Committed: https://chromium.googlesource.com/chromium/src/+/6cd1e0590f82ef11669abfbf00d846d759235460 TBR=jeffcarp@chromium.org,lushnikov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=676012 Review-Url: https://codereview.chromium.org/2676673006 Cr-Commit-Position: refs/heads/master@{#448196} Committed: https://chromium.googlesource.com/chromium/src/+/d445ec6cb5feb192e8ad5cb7d23bdac8d5a4a188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -85 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py View 1 chunk +30 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git_mock.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host.py View 2 chunks +6 lines, -56 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py View 3 chunks +4 lines, -15 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/main.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_server.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
qyearsley
Created Reland of Simplify the initialization of Git objects in Host.
3 years, 10 months ago (2017-02-04 02:02:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676673006/1
3 years, 10 months ago (2017-02-04 02:03:07 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-04 05:33:42 UTC) #5
jeffcarp
lgtm
3 years, 10 months ago (2017-02-04 23:45:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676673006/1
3 years, 10 months ago (2017-02-05 17:09:27 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 00:37:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d445ec6cb5feb192e8ad5cb7d23b...

Powered by Google App Engine
This is Rietveld 408576698