Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2676673002: Add a shortcut that opens Certificate Viewer from the Page Info flyout (Closed)

Created:
3 years, 10 months ago by elawrence
Modified:
3 years, 9 months ago
Reviewers:
palmer
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a shortcut that opens Certificate Viewer from the Page Info flyout In M56 (crbug.com/646465) we changed replaced the "Details" link on the Page Info flyout with a "Learn More" link that opens the Help Center. The old "Details" link opened the Developer Tools Security Panel (or launched the Certificate Viewer directly in the event that the Developer Tools were disabled by policy). Advanced users disliked this change as it made it significantly more cumbersome to examine the website's certificate. This change adds a shortcut to open the Certificate Viewer. Now if the SHIFT key is down when the "Learn More" link is activated, the Certificate Viewer will open directly. BUG=663971

Patch Set 1 #

Patch Set 2 : Fix build for Mac. Remove unused field. #

Patch Set 3 : Detect Shift Click on Mac PageInfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -15 lines) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 2 1 chunk +17 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 1 chunk +17 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (9 generated)
palmer
3 years, 10 months ago (2017-02-09 20:41:30 UTC) #10
lgtm

Powered by Google App Engine
This is Rietveld 408576698