Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2676653004: Show FormNotSecure warnings on sensitive inputs in non-secure contexts (Closed)

Created:
3 years, 10 months ago by estark
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Show FormNotSecure warnings on sensitive inputs in non-secure contexts Ensure that we show the on-field warnings for sensitive input fields, even if the user does not have any stored autofill data for the fields. BUG=672663 Review-Url: https://codereview.chromium.org/2640903006 Cr-Commit-Position: refs/heads/master@{#446104} (cherry picked from commit 68da9592ad01a360f95d866a6b124be8bf766337) Review-Url: https://codereview.chromium.org/2676653004 . Cr-Commit-Position: refs/branch-heads/2987@{#270} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/61c2fc567134019d5af000eb9606169f9fe395b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -47 lines) Patch
M chrome/browser/autofill/autofill_interactive_uitest.cc View 2 chunks +13 lines, -14 lines 0 comments Download
A chrome/test/data/autofill/autofill_password_form.html View 1 chunk +18 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 2 chunks +19 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 6 chunks +30 lines, -25 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
estark
3 years, 10 months ago (2017-02-02 18:39:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
61c2fc567134019d5af000eb9606169f9fe395b5.

Powered by Google App Engine
This is Rietveld 408576698