Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2676643004:
linux headless trybots keep failing to run gn (Closed)
Descriptionlinux headless trybots keep failing to run gn
Tie the debian/jessie usage to use_xkbcommon rather
than use_ozone for now.
This is more conservative and avoids problems for ozone/headless
and other bots.
BUG=687725
Review-Url: https://codereview.chromium.org/2676643004
Cr-Commit-Position: refs/heads/master@{#448468}
Committed: https://chromium.googlesource.com/chromium/src/+/ef8c544029d9e7201b3d24e87af90a97702ed5b4
Patch Set 1 #
Total comments: 2
Patch Set 2 : addressed thomasanderson's feedback #
Messages
Total messages: 26 (15 generated)
The CQ bit was checked by tonikitoo@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tonikitoo@igalia.com changed reviewers: + thomasanderson@google.com
Thomas, is this more conservative approach something you think we could leave with for now (until wheeze -> jessie materializes)?
On 2017/02/02 23:52:35, tonikitoo wrote: > Thomas, is this more conservative approach something you think we could leave > with for now (until wheeze -> jessie materializes)? s/leave/live/g
thomasanderson@google.com changed reviewers: + dpranke@chromium.org
lgtm % one comment On 2017/02/02 23:52:35, tonikitoo wrote: > Thomas, is this more conservative approach something you think we could leave > with for now (until wheeze -> jessie materializes)? I thought use_xkbcommon was what we had initially? What was the reason for changing it to use_ozone && !is_chromecast? https://codereview.chromium.org/2676643004/diff/1/build/linux/sysroot_scripts... File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2676643004/diff/1/build/linux/sysroot_scripts... build/linux/sysroot_scripts/install-sysroot.py:142: if gyp_defines.get('use_xkbcommon') == '1': This will not have the desired effect. use_xkbcommon is a gn arg, not a GYP define. You can just leave this as use_ozone. There will be some false positives (ie, we'll download the Jessie sysroot on ozone configs, but not actually use it), but this is OK for now
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/02/03 00:36:12, Tom Anderson wrote: > lgtm % one comment > > On 2017/02/02 23:52:35, tonikitoo wrote: > > Thomas, is this more conservative approach something you think we could leave > > with for now (until wheeze -> jessie materializes)? > > I thought use_xkbcommon was what we had initially? What was the reason for > changing it to use_ozone && !is_chromecast? > Reverted it back once for all.
https://codereview.chromium.org/2676643004/diff/1/build/linux/sysroot_scripts... File build/linux/sysroot_scripts/install-sysroot.py (right): https://codereview.chromium.org/2676643004/diff/1/build/linux/sysroot_scripts... build/linux/sysroot_scripts/install-sysroot.py:142: if gyp_defines.get('use_xkbcommon') == '1': On 2017/02/03 00:36:12, Tom Anderson wrote: > This will not have the desired effect. use_xkbcommon is a gn arg, not a GYP > define. > > You can just leave this as use_ozone. There will be some false positives (ie, > we'll download the Jessie sysroot on ozone configs, but not actually use it), > but this is OK for now Done.
The CQ bit was checked by tonikitoo@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
pinging dpranke
ugh ... if we need to tweak one more thing for this, I'm going to ask for a separate switch for it instead :(. lgtm in the meantime.
The CQ bit was checked by tonikitoo@igalia.com
The patchset sent to the CQ was uploaded after l-g-t-m from thomasanderson@google.com Link to the patchset: https://codereview.chromium.org/2676643004/#ps20001 (title: "addressed thomasanderson's feedback")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486422766977430,
"parent_rev": "ac3199fb6ba8ca561b09abddce556acfa9c8c5cd", "commit_rev":
"ef8c544029d9e7201b3d24e87af90a97702ed5b4"}
Message was sent while issue was closed.
Description was changed from ========== linux headless trybots keep failing to run gn Tie the debian/jessie usage to use_xkbcommon rather than use_ozone for now. This is more conservative and avoids problems for ozone/headless and other bots. BUG=687725 ========== to ========== linux headless trybots keep failing to run gn Tie the debian/jessie usage to use_xkbcommon rather than use_ozone for now. This is more conservative and avoids problems for ozone/headless and other bots. BUG=687725 Review-Url: https://codereview.chromium.org/2676643004 Cr-Commit-Position: refs/heads/master@{#448468} Committed: https://chromium.googlesource.com/chromium/src/+/ef8c544029d9e7201b3d24e87af9... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ef8c544029d9e7201b3d24e87af9...
Message was sent while issue was closed.
brettw@chromium.org changed reviewers: + brettw@chromium.org
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
