Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2676573003:
Copy item so dialog won't update model on cancel. (Closed)
|
Created:
3 years, 10 months ago by hcarmona Modified:
3 years, 10 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCopy item so dialog won't update model on cancel.
BUG=630157
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2676573003
Cr-Commit-Position: refs/heads/master@{#448102}
Committed: https://chromium.googlesource.com/chromium/src/+/032c204569668e1ea6cf0604a99a073e074c8a62
Patch Set 1 #
Total comments: 2
Patch Set 2 : feedback #Messages
Total messages: 18 (12 generated)
Description was changed from ========== Copy item so dialog won't update model on cancel. BUG=630157 ========== to ========== Copy item so dialog won't update model on cancel. BUG=630157 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hcarmona@chromium.org changed reviewers: + tommycli@chromium.org
PTAL, this makes a copy of the item before passing into the dialog.
https://codereview.chromium.org/2676573003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js (right): https://codereview.chromium.org/2676573003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:68: JSON.parse(JSON.stringify(menuEvent.model.item))); How "deep" is this object? If it's only one level, perhaps consider Object.assign({}, menuEvent.model.item)
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
https://codereview.chromium.org/2676573003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js (right): https://codereview.chromium.org/2676573003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:68: JSON.parse(JSON.stringify(menuEvent.model.item))); On 2017/02/03 19:29:43, tommycli wrote: > How "deep" is this object? If it's only one level, perhaps consider > Object.assign({}, menuEvent.model.item) Yup, only one level. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by hcarmona@chromium.org
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486153536431220,
"parent_rev": "e446ba5c0896ca5196f1d94338bab098f429289e", "commit_rev":
"032c204569668e1ea6cf0604a99a073e074c8a62"}
Message was sent while issue was closed.
Description was changed from ========== Copy item so dialog won't update model on cancel. BUG=630157 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Copy item so dialog won't update model on cancel. BUG=630157 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2676573003 Cr-Commit-Position: refs/heads/master@{#448102} Committed: https://chromium.googlesource.com/chromium/src/+/032c204569668e1ea6cf0604a99a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/032c204569668e1ea6cf0604a99a... |
