Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2676553003: mus: Fix creating the factory for window-tree-client in renderer. (Closed)

Created:
3 years, 10 months ago by sadrul
Modified:
3 years, 10 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Fix creating the factory for window-tree-client in renderer. When a new tab is created, the browser first sends the request for the window tree client to be created, and then requests the creation of a RenderWidget. However, the renderer can also create a RenderWidget and notify the browser, which then asks for the window tree client to be created. So allow the window tree client to be created correctly for a RenderWidget in both of these cases. TBR=jam@ render_widget.cc since trivial rename of a function BUG=686235 Review-Url: https://codereview.chromium.org/2676553003 Cr-Commit-Position: refs/heads/master@{#448351} Committed: https://chromium.googlesource.com/chromium/src/+/be523b7cc0438b8bb9629c5863e1959a1e9fa272

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mus/renderer_window_tree_client.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/mus/renderer_window_tree_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
sadrul
+sky@ for the changes in mus/
3 years, 10 months ago (2017-02-03 04:54:57 UTC) #6
sky
LGTM
3 years, 10 months ago (2017-02-06 16:25:24 UTC) #9
sadrul
+jam@ for content/renderer/render_widget.cc change (will TBR since function rename)
3 years, 10 months ago (2017-02-06 17:40:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676553003/20001
3 years, 10 months ago (2017-02-06 18:23:02 UTC) #15
jam
lgtm
3 years, 10 months ago (2017-02-06 18:54:03 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 19:35:58 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be523b7cc0438b8bb9629c5863e1...

Powered by Google App Engine
This is Rietveld 408576698