Issue 267653002: Tweak the FindMatchRectsDetails code to make findbugs happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267653002: Tweak the FindMatchRectsDetails code to make findbugs happy. (Closed)

Created:
6 years, 7 months ago by Lei Zhang

Modified:
6 years, 7 months ago

Reviewers:
Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, Leandro Graciá Gil

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Tweak the FindMatchRectsDetails code to make findbugs happy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267463

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -4 lines)			Patch
M	build/android/findbugs_filter/findbugs_known_bugs.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/FindMatchRectsDetails.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/267653002/1

6 years, 7 months ago (2014-04-30 23:58:31 UTC) #4

Message was sent while issue was closed.

Change committed as 267463

Expand Messages | Collapse Messages