chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java - Issue 267653002: Tweak the FindMatchRectsDetails code to make findbugs happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

Issue 267653002: Tweak the FindMatchRectsDetails code to make findbugs happy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/findbugs_filter/findbugs_known_bugs.txt ('k') | chrome/android/java/src/org/chromium/chrome/browser/FindMatchRectsDetails.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

index e745eaaf77d54d38d2a5c64c9f86ce77d0d809f1..7aa28b652e50501bf9dfb86c55f29eb825e94598 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

@@ -59,7 +59,7 @@ public class ChromeWebContentsDelegateAndroid extends WebContentsDelegateAndroid

@CalledByNative

private static FindMatchRectsDetails createFindMatchRectsDetails(

int version, int numRects, RectF activeRect) {

- return new FindMatchRectsDetails(version, new RectF[numRects], activeRect);

+ return new FindMatchRectsDetails(version, numRects, activeRect);

}

@CalledByNative