Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2676523002: Convert MediaPermissionRequestLogger to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chfremer+watch_chromium.org, mcasas+watch+vc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert MediaPermissionRequestLogger to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2676523002 Cr-Commit-Position: refs/heads/master@{#448284} Committed: https://chromium.googlesource.com/chromium/src/+/4c247781839fa869394c70ab84fa4ba77d7e07ab

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/media/webrtc/media_stream_devices_controller.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
jam
3 years, 10 months ago (2017-02-06 16:49:06 UTC) #11
Sergey Ulanov
lgtm
3 years, 10 months ago (2017-02-06 17:18:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676523002/20001
3 years, 10 months ago (2017-02-06 17:27:38 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 17:35:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c247781839fa869394c70ab84fa...

Powered by Google App Engine
This is Rietveld 408576698