Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 2676513004: Add task-list summary (Closed)

Created:
3 years, 10 months ago by kjlubick
Modified:
3 years, 10 months ago
Reviewers:
stephana, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add task-list summary This cleans up bot-list-summary as well, given the two elements are related. This removes the restriction server side that the end time must be given for a count - as that just makes queries a bit more awkward to construct. The start time is definitely required, as counting things from the beginning of time would time out. BUG=673774 Review-Url: https://codereview.chromium.org/2676513004 Committed: https://github.com/luci/luci-py/commit/eb1a0447e6c2cbc16c854ff2ea22f424bf8af0e0

Patch Set 1 #

Patch Set 2 : Add fixme for docs #

Patch Set 3 : Add documentation #

Patch Set 4 : Increase summary scope #

Total comments: 2

Patch Set 5 : Back off default to 12h #

Patch Set 6 : 24 hours by default should be ok #

Total comments: 1

Patch Set 7 : Add comments #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -38 lines) Patch
M appengine/swarming/handlers_endpoints.py View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/swarming/ui/build/elements.html View 1 2 3 4 5 6 7 3 chunks +195 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list-summary.html View 1 2 8 chunks +42 lines, -27 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list.html View 3 chunks +12 lines, -2 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list-demo.html View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
A appengine/swarming/ui/res/imp/tasklist/task-list-summary.html View 1 2 3 4 5 6 1 chunk +312 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
kjlubick
3 years, 10 months ago (2017-02-03 13:49:17 UTC) #3
M-A Ruel
python lgtm
3 years, 10 months ago (2017-02-03 17:05:22 UTC) #4
kjlubick
After talking with M-A, I expanded what the summary included: https://screenshot.googleplex.com/F8vj3EE8eBT See it live at ...
3 years, 10 months ago (2017-02-06 18:56:18 UTC) #6
M-A Ruel
https://codereview.chromium.org/2676513004/diff/60001/appengine/swarming/ui/res/imp/tasklist/task-list-summary.html File appengine/swarming/ui/res/imp/tasklist/task-list-summary.html (right): https://codereview.chromium.org/2676513004/diff/60001/appengine/swarming/ui/res/imp/tasklist/task-list-summary.html#newcode242 appengine/swarming/ui/res/imp/tasklist/task-list-summary.html:242: var last2Days = now - 2 * 24 * ...
3 years, 10 months ago (2017-02-06 20:04:33 UTC) #7
kjlubick
https://codereview.chromium.org/2676513004/diff/60001/appengine/swarming/ui/res/imp/tasklist/task-list-summary.html File appengine/swarming/ui/res/imp/tasklist/task-list-summary.html (right): https://codereview.chromium.org/2676513004/diff/60001/appengine/swarming/ui/res/imp/tasklist/task-list-summary.html#newcode242 appengine/swarming/ui/res/imp/tasklist/task-list-summary.html:242: var last2Days = now - 2 * 24 * ...
3 years, 10 months ago (2017-02-06 21:18:02 UTC) #8
stephana
lgtm modulo a nit https://codereview.chromium.org/2676513004/diff/100001/appengine/swarming/ui/res/imp/tasklist/task-list-summary.html File appengine/swarming/ui/res/imp/tasklist/task-list-summary.html (right): https://codereview.chromium.org/2676513004/diff/100001/appengine/swarming/ui/res/imp/tasklist/task-list-summary.html#newcode219 appengine/swarming/ui/res/imp/tasklist/task-list-summary.html:219: _anyBusy: function() { nit: It ...
3 years, 10 months ago (2017-02-07 19:26:18 UTC) #9
kjlubick
On 2017/02/07 at 19:26:18, stephana wrote: > lgtm modulo a nit > > https://codereview.chromium.org/2676513004/diff/100001/appengine/swarming/ui/res/imp/tasklist/task-list-summary.html > ...
3 years, 10 months ago (2017-02-07 19:31:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676513004/120001
3 years, 10 months ago (2017-02-07 19:31:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3432e199f44aae10)
3 years, 10 months ago (2017-02-07 19:33:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676513004/140001
3 years, 10 months ago (2017-02-07 19:40:39 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 19:44:43 UTC) #21
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://github.com/luci/luci-py/commit/eb1a0447e6c2cbc16c854ff2ea22f424bf8af0e0

Powered by Google App Engine
This is Rietveld 408576698