Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2676493006: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
ddorwin, wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, abarth-chromium, haraken, eme-reviews_chromium.org, blink-reviews, Srirama, xhwang, DaleCurtis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BUG=679905 We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCSTh0/edit#heading=h.xgjl2srtytjt Proposal about how to get suggested component for directory. https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9JOU/edit?ts=585868b8#heading=h.xgjl2srtytjt TEAM-COMPONENT mapping https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICAg7TYZA/edit#gid=0 Review-Url: https://codereview.chromium.org/2676493006 Cr-Commit-Position: refs/heads/master@{#450137} Committed: https://chromium.googlesource.com/chromium/src/+/c5968317007dbf2c9dba040f820d1f727c43a4cd

Patch Set 1 #

Total comments: 10

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M components/cdm/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/widevine/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-04 00:07:48 UTC) #2
ddorwin
https://codereview.chromium.org/2676493006/diff/1/components/cdm/OWNERS File components/cdm/OWNERS (right): https://codereview.chromium.org/2676493006/diff/1/components/cdm/OWNERS#newcode4 components/cdm/OWNERS:4: # COMPONENT: Blink>Media Internals>Media>Encrypted https://codereview.chromium.org/2676493006/diff/1/media/OWNERS File media/OWNERS (right): https://codereview.chromium.org/2676493006/diff/1/media/OWNERS#newcode26 ...
3 years, 10 months ago (2017-02-08 06:17:53 UTC) #3
ddorwin
Also, please update the description to be more specific. For example, "media: ..." There are ...
3 years, 10 months ago (2017-02-08 06:20:10 UTC) #4
ymzhang1
Thanks for the comments! Yes. There would be more cls for media directories. Our plan ...
3 years, 10 months ago (2017-02-10 00:10:46 UTC) #5
ddorwin
lgtm
3 years, 10 months ago (2017-02-12 04:00:52 UTC) #6
ddorwin
wolenetz@chromium.org: Please review changes in mediasource
3 years, 10 months ago (2017-02-12 04:01:25 UTC) #8
wolenetz
mediasource lgtm
3 years, 10 months ago (2017-02-13 21:42:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676493006/20001
3 years, 10 months ago (2017-02-13 21:44:53 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 23:08:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c5968317007dbf2c9dba040f820d...

Powered by Google App Engine
This is Rietveld 408576698