Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2676493005
Cr-Commit-Position: refs/heads/master@{#449389}
Committed: https://chromium.googlesource.com/chromium/src/+/a599f3cce3cc1149ca1dd745153ac32bd4600574

[zakerinasab, 2017-02-03 17:45:02]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-03 17:45:02]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[zakerinasab, 2017-02-03 17:45:16]

CL uploaded. PTAL.

[Justin Novosad, 2017-02-03 18:39:32]

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fill-zeroSizeGradient.html
(right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fill-zeroSizeGradient.html:6:
var ctx = document.createElement('canvas').getContext('2d');
indent

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-zeroSizeGradient.html
(right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-zeroSizeGradient.html:6:
var ctx = document.createElement('canvas').getContext('2d');
indent

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillText-invalid-maxWidth.html
(right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillText-invalid-maxWidth.html:7:
var canvas = document.createElement('canvas');
indent

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillText-invalid-maxWidth.html:25:
if (d[4 * (w * i + j) + 0] != 0) assert_equals(d[4 * (w * i + j) + 0], 0);
Calling assert_equals inside a big loop is a bad idea because it will flood the
output when it fails.  Better to use a variable to track pass/fail and have a
single assert at the end.  Ex:
var testPassed = true;
for (...) {
  if (...)
    testPassed = false;
}
assert_equals(testPassed, true);

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillText-invalid-maxWidth.html:42:
if (d[4 * (w * i + j) + 0] != 0) assert_equals(d[4 * (w * i + j) + 0], 0);
same here

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-font-cache.html (right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-font-cache.html:7: // The
reason this is implemented as a layout test instead of a unit test (see
CanvasFontCacheTest.cpp)
indent

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-font-ex-units-crash.html
(right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-font-ex-units-crash.html:7:
ctx = document.createElement('canvas').getContext('2d');
indent

[zakerinasab, 2017-02-09 18:11:03]

Overall comments addressed. PTAL.

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fill-zeroSizeGradient.html
(right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fill-zeroSizeGradient.html:6:
var ctx = document.createElement('canvas').getContext('2d');
On 2017/02/03 18:39:32, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-zeroSizeGradient.html
(right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillRect-zeroSizeGradient.html:6:
var ctx = document.createElement('canvas').getContext('2d');
On 2017/02/03 18:39:32, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillText-invalid-maxWidth.html
(right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillText-invalid-maxWidth.html:7:
var canvas = document.createElement('canvas');
On 2017/02/03 18:39:32, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillText-invalid-maxWidth.html:25:
if (d[4 * (w * i + j) + 0] != 0) assert_equals(d[4 * (w * i + j) + 0], 0);
On 2017/02/03 18:39:32, Justin Novosad wrote:
> Calling assert_equals inside a big loop is a bad idea because it will flood
the
> output when it fails.  Better to use a variable to track pass/fail and have a
> single assert at the end.  Ex:
> var testPassed = true;
> for (...) {
>   if (...)
>     testPassed = false;
> }
> assert_equals(testPassed, true);

Done.

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-fillText-invalid-maxWidth.html:42:
if (d[4 * (w * i + j) + 0] != 0) assert_equals(d[4 * (w * i + j) + 0], 0);
On 2017/02/03 18:39:32, Justin Novosad wrote:
> same here

Done.

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-font-cache.html (right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-font-cache.html:7: // The
reason this is implemented as a layout test instead of a unit test (see
CanvasFontCacheTest.cpp)
On 2017/02/03 18:39:32, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-font-ex-units-crash.html
(right):

https://codereview.chromium.org/2676493005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-font-ex-units-crash.html:7:
ctx = document.createElement('canvas').getContext('2d');
On 2017/02/03 18:39:32, Justin Novosad wrote:
> indent

Done.

[Justin Novosad, 2017-02-09 19:41:37]

lgtm

[zakerinasab, 2017-02-09 19:46:35]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-02-09 19:47:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 20:20:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486669595498470,
"parent_rev": "fc267acdc19975a3372b8c982810650034c396cd", "commit_rev":
"a599f3cce3cc1149ca1dd745153ac32bd4600574"}

[commit-bot: I haz the power, 2017-02-09 20:21:21]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2676493005
Cr-Commit-Position: refs/heads/master@{#449389}
Committed:
https://chromium.googlesource.com/chromium/src/+/a599f3cce3cc1149ca1dd745153a...
==========

[commit-bot: I haz the power, 2017-02-09 20:21:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a599f3cce3cc1149ca1dd745153a...