Split MediaMetadata::MediaImage from Manifest::Icon

Split MediaMetadata::MediaImage from Manifest::Icon

Now Manifest::Icon has new members that doesn't apply to MediaImage. We
should split the two structs.

BUG=621859
Review-Url: https://codereview.chromium.org/2676493004
Cr-Commit-Position: refs/heads/master@{#448589}
Committed: https://chromium.googlesource.com/chromium/src/+/e9387b26fd3057e265d2061d4063ec1634a32e5a

[Zhiqiang Zhang (Slow), 2017-02-03 16:24:21]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 16:24:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 17:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 17:34:58]

Dry run: This issue passed the CQ dry run.

[Zhiqiang Zhang (Slow), 2017-02-06 11:40:51]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-06 12:43:22]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org
- mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-06 12:43:23]

s/mlamouri/avayvod to balance the review :)

[whywhat, 2017-02-06 18:11:06]

lgtm

would making Manifest::Icon inherit from or embed MediaImage make sense?

[Zhiqiang Zhang (Slow), 2017-02-06 18:17:59]

On 2017/02/06 18:11:06, whywhat_slow_PST_till_Feb_6 wrote:
> lgtm
> 
> would making Manifest::Icon inherit from or embed MediaImage make sense?

I think we could do it if the two interfaces start to merge some day.
However I suppose they are evolving in their own directions.

[Zhiqiang Zhang (Slow), 2017-02-06 18:18:05]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2017-02-06 18:18:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 18:28:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 18:28:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Zhiqiang Zhang (Slow), 2017-02-06 19:42:16]

zqzhang@chromium.org changed reviewers:
+ avi@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-06 19:42:16]

+avi@ for approval

[Avi (use Gerrit), 2017-02-06 19:44:48]

lgtm

[Zhiqiang Zhang (Slow), 2017-02-07 10:42:21]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2017-02-07 10:42:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 10:46:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486464141194940, "parent_rev":
"5e29fc4efdebf1b343ab1a5eb1e52b258be4eeab", "commit_rev":
"e9387b26fd3057e265d2061d4063ec1634a32e5a"}

[commit-bot: I haz the power, 2017-02-07 10:47:25]

Description was changed from

==========
Split MediaMetadata::MediaImage from Manifest::Icon

Now Manifest::Icon has new members that doesn't apply to MediaImage. We
should split the two structs.

BUG=621859
==========

to

==========
Split MediaMetadata::MediaImage from Manifest::Icon

Now Manifest::Icon has new members that doesn't apply to MediaImage. We
should split the two structs.

BUG=621859

Review-Url: https://codereview.chromium.org/2676493004
Cr-Commit-Position: refs/heads/master@{#448589}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9387b26fd3057e265d2061d4063...
==========

[commit-bot: I haz the power, 2017-02-07 10:47:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9387b26fd3057e265d2061d4063...