Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2676443002: [Android] Further speculative fixes for search engine crashes. (Closed)

Created:
3 years, 10 months ago by Ted C
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Android] Further speculative fixes for search engine crashes. Noticed that the .equals for TemplateUrl was not including the new fields added recently. The previous CL was not updating the search engines if they equalled, but that would not work if the keywords changed, which is the key used to query the backend. This handles the null in cases we are aware of, logs information that we can traige further, but should unblock custom search engines on Android. BUG=670250 Review-Url: https://codereview.chromium.org/2668593002 Cr-Commit-Position: refs/heads/master@{#447195} (cherry picked from commit 14c9281bb6a538be7e6d7f278d4fea7d5e838d08) Review-Url: https://codereview.chromium.org/2676443002 . Cr-Commit-Position: refs/branch-heads/2987@{#258} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3a2e7d7b51a3d44233591e67fb9285b29e9d5f5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -15 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java View 8 chunks +30 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java View 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Ted C
3 years, 10 months ago (2017-02-01 23:59:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a2e7d7b51a3d44233591e67fb9285b29e9d5f5c.

Powered by Google App Engine
This is Rietveld 408576698