Convert OfflineAudioContext Audit tests to testharness

Convert OfflineAudioContext Audit tests to testharness

Used the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Still needed to convert manually some uses of testPassed/testFailed
and some old js-test functions.

BUG=689076
TEST=offlineaudiocontext-promise-basic.html,
offlineaudiocontext-suspend-resume-basic.html

Review-Url: https://codereview.chromium.org/2676343003
Cr-Commit-Position: refs/heads/master@{#450472}
Committed: https://chromium.googlesource.com/chromium/src/+/8aca6ce1196fca0dc0cca083b24be9b483f0dc3d

[Raymond Toy, 2017-02-07 17:01:39]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-07 17:01:39]

PTAL

[hongchan, 2017-02-07 18:26:15]

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html
(right):

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html:12:
//      description("Test OfflineAudioContext.startRendering Promise")
Remove this line.

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html:56:
done();
I think we can remove this task because we don't need to call finishJSTest()
anymore.

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html:92:
successfullyParsed = true;
This line is not needed.

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html
(right):

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html:76:
}))
Perhaps:

() => {
  context.suspend(suspendTime1)
    .then(() => context.resume());
})
.notThrow();

We should stick to the new ES6 arrow notation for the anonymous function.

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html:134:
});
This task can be removed.

[Raymond Toy, 2017-02-14 16:27:57]

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html
(right):

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html:12:
//      description("Test OfflineAudioContext.startRendering Promise")
On 2017/02/07 18:26:15, hongchan wrote:
> Remove this line.

Done.

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html:56:
done();
On 2017/02/07 18:26:15, hongchan wrote:
> I think we can remove this task because we don't need to call finishJSTest()
> anymore.

Done.

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html:92:
successfullyParsed = true;
On 2017/02/07 18:26:15, hongchan wrote:
> This line is not needed.

Done.

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html
(right):

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html:76:
}))
On 2017/02/07 18:26:15, hongchan wrote:
> Perhaps:
> 
> () => {
>   context.suspend(suspendTime1)
>     .then(() => context.resume());
> })
> .notThrow();
> 
> We should stick to the new ES6 arrow notation for the anonymous function.

Done. And reindented using clang-format.

https://codereview.chromium.org/2676343003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html:134:
});
On 2017/02/07 18:26:15, hongchan wrote:
> This task can be removed.

Done.

[hongchan, 2017-02-14 18:07:26]

lgtm with nits

https://codereview.chromium.org/2676343003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html
(right):

https://codereview.chromium.org/2676343003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html:76:
.notThrow();
Is this the result from clang-format? If not, please run it on this diff.

https://codereview.chromium.org/2676343003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html:114:
.notThrow();
I believe l.73~76 should look like this.

[Raymond Toy, 2017-02-14 18:43:14]

https://codereview.chromium.org/2676343003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html
(right):

https://codereview.chromium.org/2676343003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html:76:
.notThrow();
On 2017/02/14 18:07:26, hongchan wrote:
> Is this the result from clang-format? If not, please run it on this diff.

Yes, I used clang-format for this.  But removing the extra {} on line 75 makes
it indent the way you want.

[Raymond Toy, 2017-02-14 19:56:25]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-02-14 19:56:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2676343003/#ps40001
(title: "Address review comments.")

[commit-bot: I haz the power, 2017-02-14 19:57:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 21:09:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487102185957080,
"parent_rev": "a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb", "commit_rev":
"8aca6ce1196fca0dc0cca083b24be9b483f0dc3d"}

[commit-bot: I haz the power, 2017-02-14 21:09:53]

Description was changed from

==========
Convert OfflineAudioContext Audit tests to testharness

Used the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Still needed to convert manually some uses of testPassed/testFailed
and some old js-test functions.

BUG=689076
TEST=offlineaudiocontext-promise-basic.html,
offlineaudiocontext-suspend-resume-basic.html
==========

to

==========
Convert OfflineAudioContext Audit tests to testharness

Used the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  if [ -f $base-expected.txt ]; then
      git rm $base-expected.txt
  fi
done

Still needed to convert manually some uses of testPassed/testFailed
and some old js-test functions.

BUG=689076
TEST=offlineaudiocontext-promise-basic.html,
offlineaudiocontext-suspend-resume-basic.html

Review-Url: https://codereview.chromium.org/2676343003
Cr-Commit-Position: refs/heads/master@{#450472}
Committed:
https://chromium.googlesource.com/chromium/src/+/8aca6ce1196fca0dc0cca083b24b...
==========

[commit-bot: I haz the power, 2017-02-14 21:09:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8aca6ce1196fca0dc0cca083b24b...