Reimplement BluetoothSocketChromeOS

device/bluetooth/bluetooth_socket.h

Index: device/bluetooth/bluetooth_socket.h
diff --git a/device/bluetooth/bluetooth_socket.h b/device/bluetooth/bluetooth_socket.h
index a23efa31287fc36ef1d3e6d1999cdfbaba5c6ac9..7a41a2f25075922d142202c89d6ec7a52b27cc94 100644
--- a/device/bluetooth/bluetooth_socket.h
+++ b/device/bluetooth/bluetooth_socket.h
@@ -43,7 +43,7 @@ class BluetoothSocket : public base::RefCountedThreadSafe<BluetoothSocket> {
 
   // Gracefully disconnects the socket and calls |callback| upon completion.

[armansito, 2014/05/01 00:14:25]

If you're set on using |success_callback| as the name, then update the comment.

[keybuk, 2014/05/01 00:24:09]

ACK

   // There is no failure case, as this is a best effort operation.
-  virtual void Disconnect(const base::Closure& callback) = 0;
+  virtual void Disconnect(const base::Closure& success_callback) = 0;

[armansito, 2014/05/01 00:14:25]

Might as well leave it as |callback|, since it is a best effort operation. If
things internally failed, we just don't report it, so "success" may not be true.

[keybuk, 2014/05/01 00:24:09]

yeah I had added an error_callback but decided not do to... I guess I forgot I
renamed this ;-)

 
   // Receives data from the socket and calls |success_callback| when data is
   // available. |buffer_size| specifies the maximum number of bytes that can be