Reimplement BluetoothSocketChromeOS

device/bluetooth/bluetooth_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_SOCKET_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_SOCKET_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 23 matching lines @@
   typedef base::Callback<void(const std::string& error_message)>
       ErrorCompletionCallback;
   typedef base::Callback<void(ErrorReason, const std::string& error_message)>
       ReceiveErrorCompletionCallback;
 
   // Destroys resources associated with the socket. After calling this method,
   // it is illegal to call any method on this socket instance (except for the
   // desctrutor via Release).
   virtual void Close() = 0;
 
   // Gracefully disconnects the socket and calls |callback| upon completion.

[armansito, 2014/05/01 00:14:25]

If you're set on using |success_callback| as the name, then update the comment.

[keybuk, 2014/05/01 00:24:09]

ACK

   // There is no failure case, as this is a best effort operation.
-  virtual void Disconnect(const base::Closure& callback) = 0;
+  virtual void Disconnect(const base::Closure& success_callback) = 0;

[armansito, 2014/05/01 00:14:25]

Might as well leave it as |callback|, since it is a best effort operation. If
things internally failed, we just don't report it, so "success" may not be true.

[keybuk, 2014/05/01 00:24:09]

yeah I had added an error_callback but decided not do to... I guess I forgot I
renamed this ;-)

 
   // Receives data from the socket and calls |success_callback| when data is
   // available. |buffer_size| specifies the maximum number of bytes that can be
   // received. If an error occurs, calls |error_callback| with a reason and an
   // error message.
   virtual void Receive(
       int buffer_size,
       const ReceiveCompletionCallback& success_callback,
       const ReceiveErrorCompletionCallback& error_callback) = 0;
 
   // Sends |buffer| to the socket and calls |success_callback| when data has
   // been successfully sent. |buffer_size| is the number of bytes contained in
   // |buffer|. If an error occurs, calls |error_callback| with an error message.
   virtual void Send(scoped_refptr<net::IOBuffer> buffer,
                     int buffer_size,
                     const SendCompletionCallback& success_callback,
                     const ErrorCompletionCallback& error_callback) = 0;
 
  protected:
   friend class base::RefCountedThreadSafe<BluetoothSocket>;
   virtual ~BluetoothSocket();
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_SOCKET_H_