Source/core/xml/XPathPath.h - Issue 26763004: Vector stores Expression object as OwnPtr instead of raw pointer in XPath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathPath.h

Issue 26763004: Vector stores Expression object as OwnPtr instead of raw pointer in XPath. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change XPathGrammar.y also Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XPathPath.h

diff --git a/Source/core/xml/XPathPath.h b/Source/core/xml/XPathPath.h

index 2b18e8be48eaf7c547a27db35009960c3ae73ae8..b3b9c06dcc4938a1c47835d81bd5f1bf33ad0c4c 100644

--- a/Source/core/xml/XPathPath.h

+++ b/Source/core/xml/XPathPath.h

@@ -39,7 +39,7 @@ namespace WebCore {

class Filter : public Expression {

public:

- Filter(Expression*, const Vector<Predicate*>& = Vector<Predicate*>());

+ Filter(PassOwnPtr<Expression>, const Vector<Predicate*>& = Vector<Predicate*>());

virtual ~Filter();

virtual Value evaluate() const;

@@ -47,8 +47,8 @@ namespace WebCore {

private:

virtual Value::Type resultType() const { return Value::NodeSetValue; }

- Expression* m_expr;

- Vector<Predicate*> m_predicates;

+ OwnPtr<Expression> m_expr;

+ Vector<OwnPtr<Predicate> > m_predicates;

};

class LocationPath : public Expression {

« Source/core/xml/XPathFunctions.h ('K') | « Source/core/xml/XPathParser.cpp ('k') | Source/core/xml/XPathPath.cpp » ('j') | Source/core/xml/XPathPath.cpp » ('J')