Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: Source/core/xml/XPathFunctions.h

Issue 26763004: Vector stores Expression object as OwnPtr instead of raw pointer in XPath. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change XPathGrammar.y also Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/xml/XPathFunctions.h
diff --git a/Source/core/xml/XPathFunctions.h b/Source/core/xml/XPathFunctions.h
index 0482884374c13345cd635c32592571a9c0f6d1a6..1e2ee4de5bfc100bd61804439957ab04d7fd7db2 100644
--- a/Source/core/xml/XPathFunctions.h
+++ b/Source/core/xml/XPathFunctions.h
@@ -35,7 +35,7 @@ namespace WebCore {
class Function : public Expression {
public:
- void setArguments(const Vector<Expression*>&);
+ void setArguments(Vector<OwnPtr<Expression> >&);
void setName(const String& name) { m_name = name; }
protected:
Expression* arg(int pos) { return subExpr(pos); }
@@ -47,7 +47,8 @@ namespace WebCore {
String m_name;
};
- Function* createFunction(const String& name, const Vector<Expression*>& args = Vector<Expression*>());
dshwang 2013/10/14 15:56:04 Currently, Vector has a bug as follows Vector<OwnP
+ Function* createFunction(const String& name);
+ Function* createFunction(const String& name, Vector<OwnPtr<Expression> >&);
} // namespace XPath

Powered by Google App Engine
This is Rietveld 408576698