Source/core/xml/XPathParser.h - Issue 26763004: Vector stores Expression object as OwnPtr instead of raw pointer in XPath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathParser.h

Issue 26763004: Vector stores Expression object as OwnPtr instead of raw pointer in XPath. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change XPathGrammar.y also Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XPathParser.h

diff --git a/Source/core/xml/XPathParser.h b/Source/core/xml/XPathParser.h

index 57c6dc5d9ab6e774e0db513d1e66fa2dcbf04c95..e837c4dcb10cde20500d6116964d38fb61a1676e 100644

--- a/Source/core/xml/XPathParser.h

+++ b/Source/core/xml/XPathParser.h

@@ -79,8 +79,8 @@ public:

void registerPredicateVector(Vector<Predicate*>*);

void deletePredicateVector(Vector<Predicate*>*);

- void registerExpressionVector(Vector<Expression*>*);

- void deleteExpressionVector(Vector<Expression*>*);

+ void registerExpressionVector(Vector<OwnPtr<Expression> >*);

+ void deleteExpressionVector(Vector<OwnPtr<Expression> >*);

void registerString(String*);

void deleteString(String*);

@@ -117,7 +117,7 @@ private:

HashSet<ParseNode*> m_parseNodes;

HashSet<Vector<Predicate*>*> m_predicateVectors;

- HashSet<Vector<Expression*>*> m_expressionVectors;

+ HashSet<Vector<OwnPtr<Expression> >*> m_expressionVectors;

HashSet<String*> m_strings;

HashSet<Step::NodeTest*> m_nodeTests;

};

« Source/core/xml/XPathFunctions.h ('K') | « Source/core/xml/XPathGrammar.y ('k') | Source/core/xml/XPathParser.cpp » ('j') | Source/core/xml/XPathPath.cpp » ('J')