Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2676193002: [tests] add microbenchmark for %TypedArray%.prototype.copyWithin (Closed)

Created:
3 years, 10 months ago by caitp
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] add microbenchmark for %TypedArray%.prototype.copyWithin Add a simple microbenchmark for calling copyWithin on a moderately large Float64Array with 10,000 elements. BUG=v8:5925, v8:5929, v8:4648 R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org Review-Url: https://codereview.chromium.org/2676193002 Cr-Commit-Position: refs/heads/master@{#42944} Committed: https://chromium.googlesource.com/v8/v8/+/d36f14a73dbb7a907d0cdc6dd36ebd1781c1ba28

Patch Set 1 #

Patch Set 2 : Remove heap-symbols.h change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M test/js-perf-test/JSTests.json View 1 chunk +12 lines, -0 lines 0 comments Download
A test/js-perf-test/TypedArrays/run.js View 1 chunk +27 lines, -0 lines 0 comments Download
A test/js-perf-test/TypedArrays/typedarrays.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
caitp
Just the test, as requested
3 years, 10 months ago (2017-02-06 03:11:17 UTC) #1
Benedikt Meurer
Thanks. LGTN
3 years, 10 months ago (2017-02-06 03:49:22 UTC) #3
Benedikt Meurer
On 2017/02/06 03:49:22, Benedikt Meurer wrote: > Thanks. LGTN LGTM of course :-)
3 years, 10 months ago (2017-02-06 03:49:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676193002/20001
3 years, 10 months ago (2017-02-06 03:58:15 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 04:20:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d36f14a73dbb7a907d0cdc6dd36ebd1781c...

Powered by Google App Engine
This is Rietveld 408576698