Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp

Issue 2676163002: Refactor the forPreload flag to mean speculative preload. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp b/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
index 510afc9cc5a188453f7b19aeebbbefb60964adc7..831a69bae0f66cdaa4527ca01a6b2dc7eacd1f0a 100644
--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
@@ -258,10 +258,10 @@ ResourceRequestBlockedReason ResourceLoader::canAccessResponse(
Resource* resource,
const ResourceResponse& response) const {
// Redirects can change the response URL different from one of request.
- bool forPreload = resource->isUnusedPreload();
+ bool unusedPreload = resource->isUnusedPreload();
ResourceRequestBlockedReason blockedReason =
context().canRequest(resource->getType(), resource->resourceRequest(),
- response.url(), resource->options(), forPreload,
+ response.url(), resource->options(), unusedPreload,
Charlie Harrison 2017/02/05 18:39:12 nit: inline comment that this bool is used to supp
Yoav Weiss 2017/02/06 09:58:35 enummed
FetchRequest::UseDefaultOriginRestrictionForType);
if (blockedReason != ResourceRequestBlockedReason::None)
return blockedReason;
@@ -286,7 +286,7 @@ ResourceRequestBlockedReason ResourceLoader::canAccessResponse(
sourceOrigin);
if (corsStatus != CrossOriginAccessControl::kAccessAllowed) {
resource->setCORSFailed();
- if (!forPreload) {
+ if (!unusedPreload) {
String resourceType = Resource::resourceTypeToString(
resource->getType(), resource->options().initiatorInfo.name);
StringBuilder builder;

Powered by Google App Engine
This is Rietveld 408576698