Refactor the forPreload flag to mean speculative preload.

third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2007 Graham Dennis (graham.dennis@gmail.com)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 240 matching lines @@
 }
 
 FetchContext& ResourceLoader::context() const {
   return m_fetcher->context();
 }
 
 ResourceRequestBlockedReason ResourceLoader::canAccessResponse(
     Resource* resource,
     const ResourceResponse& response) const {
   // Redirects can change the response URL different from one of request.
-  bool forPreload = resource->isUnusedPreload();
+  bool unusedPreload = resource->isUnusedPreload();
   ResourceRequestBlockedReason blockedReason =
       context().canRequest(resource->getType(), resource->resourceRequest(),
-                           response.url(), resource->options(), forPreload,
+                           response.url(), resource->options(), unusedPreload,

[Charlie Harrison, 2017/02/05 18:39:12]

nit: inline comment that this bool is used to suppress reports 

[Yoav Weiss, 2017/02/06 09:58:35]

enummed

                            FetchRequest::UseDefaultOriginRestrictionForType);
   if (blockedReason != ResourceRequestBlockedReason::None)
     return blockedReason;
 
   SecurityOrigin* sourceOrigin = resource->options().securityOrigin.get();
   if (!sourceOrigin)
     sourceOrigin = context().getSecurityOrigin();
 
   if (sourceOrigin->canRequestNoSuborigin(response.url()))
     return ResourceRequestBlockedReason::None;
 
   // Use the original response instead of the 304 response for a successful
   // revaldiation.
   const ResourceResponse& responseForAccessControl =
       (resource->isCacheValidator() && response.httpStatusCode() == 304)
           ? resource->response()
           : response;
 
   CrossOriginAccessControl::AccessStatus corsStatus =
       CrossOriginAccessControl::checkAccess(
           responseForAccessControl, resource->options().allowCredentials,
           sourceOrigin);
   if (corsStatus != CrossOriginAccessControl::kAccessAllowed) {
     resource->setCORSFailed();
-    if (!forPreload) {
+    if (!unusedPreload) {
       String resourceType = Resource::resourceTypeToString(
           resource->getType(), resource->options().initiatorInfo.name);
       StringBuilder builder;
       builder.append("Access to ");
       builder.append(resourceType);
       builder.append(" at '");
       builder.append(response.url().getString());
       builder.append("' from origin '");
       builder.append(sourceOrigin->toString());
       builder.append("' has been blocked by CORS policy: ");
@@ skipping 213 matching lines @@
     return;
 
   // Don't activate if cache policy is explicitly set.
   if (request.getCachePolicy() != WebCachePolicy::UseProtocolCachePolicy)
     return;
 
   m_isCacheAwareLoadingActivated = true;
 }
 
 }  // namespace blink