Refactor the forPreload flag to mean speculative preload.

third_party/WebKit/Source/core/loader/resource/ImageResource.cpp

Index: third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
diff --git a/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp b/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
index f3c3221bbc7ea871a40579cbb28be63ab2f888d6..8a17b7c2f72033dc033422dc40bbe9a87d483360 100644
--- a/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
+++ b/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
@@ -155,7 +155,7 @@ ImageResource* ImageResource::fetch(FetchRequest& request,
     if (requestURL.isValid()) {
       ResourceRequestBlockedReason blockReason = fetcher->context().canRequest(
           Resource::Image, request.resourceRequest(), requestURL,
-          request.options(), request.forPreload(),
+          request.options(), request.speculativePreload(),

[Charlie Harrison, 2017/02/05 18:39:11]

nit: Can you inline /* suppressReport */ here? It is not immediately clear that
that's what this bool is doing.

[Yoav Weiss, 2017/02/06 09:58:35]

I agree that currently the call-site is not very clear, but maybe an enum would
be a better choice to make the semantics conversion (i.e. preload/unusedPreload
means suppressed logs/reports) explicit. They also enforce an explicit decision
from all call sites, and called out as preferred in the style guide.

Let me know what you think.

[Charlie Harrison, 2017/02/06 19:54:15]

Yes an enum sounds good.

           request.getOriginRestriction());
       if (blockReason == ResourceRequestBlockedReason::None)
         fetcher->context().sendImagePing(requestURL);