Refactor the forPreload flag to mean speculative preload.

third_party/WebKit/Source/core/loader/resource/ImageResource.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 137 matching lines @@
   if (request.resourceRequest().requestContext() ==
       WebURLRequest::RequestContextUnspecified) {
     request.mutableResourceRequest().setRequestContext(
         WebURLRequest::RequestContextImage);
   }
   if (fetcher->context().pageDismissalEventBeingDispatched()) {
     KURL requestURL = request.resourceRequest().url();
     if (requestURL.isValid()) {
       ResourceRequestBlockedReason blockReason = fetcher->context().canRequest(
           Resource::Image, request.resourceRequest(), requestURL,
-          request.options(), request.forPreload(),
+          request.options(), request.speculativePreload(),

[Charlie Harrison, 2017/02/05 18:39:11]

nit: Can you inline /* suppressReport */ here? It is not immediately clear that
that's what this bool is doing.

[Yoav Weiss, 2017/02/06 09:58:35]

I agree that currently the call-site is not very clear, but maybe an enum would
be a better choice to make the semantics conversion (i.e. preload/unusedPreload
means suppressed logs/reports) explicit. They also enforce an explicit decision
from all call sites, and called out as preferred in the style guide.

Let me know what you think.

[Charlie Harrison, 2017/02/06 19:54:15]

Yes an enum sounds good.

           request.getOriginRestriction());
       if (blockReason == ResourceRequestBlockedReason::None)
         fetcher->context().sendImagePing(requestURL);
     }
     return nullptr;
   }
 
   ImageResource* resource = toImageResource(
       fetcher->requestResource(request, ImageResourceFactory(request)));
   if (resource &&
@@ skipping 340 matching lines @@
 
 void ImageResource::updateImage(
     PassRefPtr<SharedBuffer> sharedBuffer,
     ImageResourceContent::UpdateImageOption updateImageOption,
     bool allDataReceived) {
   getContent()->updateImage(std::move(sharedBuffer), updateImageOption,
                             allDataReceived);
 }
 
 }  // namespace blink