Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 267613003: location.replace() breaks same-document back/forward navigations. (Closed)

Created:
6 years, 7 months ago by Nate Chapin
Modified:
6 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

location.replace() breaks same-document back/forward navigations. For navigations that don't create a new entry in the back/forward list (like location.replace), we don't create a new HistoryItem, we just update the existing one. If the url changes, we currently update some id numbers as well: the item sequence number (which uniquely identifies the item), and the document sequence number (which is common among history items that can be navigated between without creating a new document). For a location.replace() within the same document, we still need to change the item sequence number (so that a back navigation is guaranteed to do something), but the document sequence number should *not* update, so that a same-document navigation is still possible. BUG=363724 TEST=fast/loader/back-after-same-document-location-replace.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
A LayoutTests/fast/loader/back-after-same-document-location-replace.html View 1 chunk +24 lines, -0 lines 0 comments Download
A + LayoutTests/fast/loader/back-after-same-document-location-replace-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/loader/HistoryItem.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/loader/HistoryItem.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nate Chapin
6 years, 7 months ago (2014-04-30 22:25:12 UTC) #1
abarth-chromium
lgtm
6 years, 7 months ago (2014-04-30 22:41:52 UTC) #2
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 7 months ago (2014-04-30 22:44:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/267613003/1
6 years, 7 months ago (2014-04-30 22:44:47 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 00:42:51 UTC) #5
Message was sent while issue was closed.
Change committed as 173045

Powered by Google App Engine
This is Rietveld 408576698