Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: Source/core/loader/HistoryItem.cpp

Issue 267613003: location.replace() breaks same-document back/forward navigations. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/HistoryItem.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2008, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 : m_pageScaleFactor(0) 46 : m_pageScaleFactor(0)
47 , m_itemSequenceNumber(generateSequenceNumber()) 47 , m_itemSequenceNumber(generateSequenceNumber())
48 , m_documentSequenceNumber(generateSequenceNumber()) 48 , m_documentSequenceNumber(generateSequenceNumber())
49 { 49 {
50 } 50 }
51 51
52 HistoryItem::~HistoryItem() 52 HistoryItem::~HistoryItem()
53 { 53 {
54 } 54 }
55 55
56 void HistoryItem::generateNewSequenceNumbers() 56 void HistoryItem::generateNewItemSequenceNumber()
57 { 57 {
58 m_itemSequenceNumber = generateSequenceNumber(); 58 m_itemSequenceNumber = generateSequenceNumber();
59 }
60
61 void HistoryItem::generateNewDocumentSequenceNumber()
62 {
59 m_documentSequenceNumber = generateSequenceNumber(); 63 m_documentSequenceNumber = generateSequenceNumber();
60 } 64 }
61 65
62 const String& HistoryItem::urlString() const 66 const String& HistoryItem::urlString() const
63 { 67 {
64 return m_urlString; 68 return m_urlString;
65 } 69 }
66 70
67 KURL HistoryItem::url() const 71 KURL HistoryItem::url() const
68 { 72 {
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 } 213 }
210 214
211 bool HistoryItem::isCurrentDocument(Document* doc) const 215 bool HistoryItem::isCurrentDocument(Document* doc) const
212 { 216 {
213 // FIXME: We should find a better way to check if this is the current docume nt. 217 // FIXME: We should find a better way to check if this is the current docume nt.
214 return equalIgnoringFragmentIdentifier(url(), doc->url()); 218 return equalIgnoringFragmentIdentifier(url(), doc->url());
215 } 219 }
216 220
217 } // namespace WebCore 221 } // namespace WebCore
218 222
OLDNEW
« no previous file with comments | « Source/core/loader/HistoryItem.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698