MD Settings: Move bluetooth UI from dialog to subpage

MD Settings: Move bluetooth UI from dialog to subpage

This CL does the following:
1. Moves the list of paired devices from the dialog the subpage.
2. Updates the top level bluetooth page to be two lines (with enabled state in the second line) with a toggle switch (similar to Autofill settings or Manage paswords).
3. Moves the spinner to be in the same row as the 'Unpaired devices' subtitle in the subpage.

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2676103002
Cr-Commit-Position: refs/heads/master@{#449123}
Committed: https://chromium.googlesource.com/chromium/src/+/1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5

[stevenjb, 2017-02-04 03:03:21]

Description was changed from

==========
MD Settings: Move bluetooth UI from dialog to subpage

BUG=673946
==========

to

==========
MD Settings: Move bluetooth UI from dialog to subpage

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-06 23:59:00]

Description was changed from

==========
MD Settings: Move bluetooth UI from dialog to subpage

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Move bluetooth UI from dialog to subpage

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-07 00:05:21]

Description was changed from

==========
MD Settings: Move bluetooth UI from dialog to subpage

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Move bluetooth UI from dialog to subpage

This CL does the following:
1. Moves the list of paired devices from the dialog the subpage.
2. Updates the top level bluetooth page to be two lines (with enabled state in
the second line) with a toggle switch (similar to Autofill settings or Manage
paswords).
3. Moves the spinner to be in the same row as the 'Unpaired devices' subtitle in
the subpage.

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-07 00:05:29]

stevenjb@chromium.org changed reviewers:
+ fukino@chromium.org

[fukino, 2017-02-08 16:58:24]

I'm sorry for a late response!
LGTM with nits.

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
(right):

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:9:
// NOTE(dbeam): even though this behaviors is only used privately, it must
nit: s/behaviors/behavior

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js
(right):

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js:11: //
NOTE(dbeam): even though this behaviors is only used privately, it must
nit: s/behaviors/behavior

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js:221: }
else{
nit: space after else

[stevenjb, 2017-02-08 20:27:01]

No worries, thanks for the review!

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
(right):

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:9:
// NOTE(dbeam): even though this behaviors is only used privately, it must
On 2017/02/08 16:58:23, fukino wrote:
> nit: s/behaviors/behavior

Done.

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js
(right):

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js:11: //
NOTE(dbeam): even though this behaviors is only used privately, it must
On 2017/02/08 16:58:24, fukino wrote:
> nit: s/behaviors/behavior

Done.

https://codereview.chromium.org/2676103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js:221: }
else{
On 2017/02/08 16:58:23, fukino wrote:
> nit: space after else

Done.

[stevenjb, 2017-02-08 20:27:26]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-02-08 20:27:27]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2676103002/#ps60001
(title: "Feedback")

[commit-bot: I haz the power, 2017-02-08 20:28:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:04:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486585646675780,
"parent_rev": "92f1868b4b0a675218d0c1b6bd7fa96e3e1a3a9d", "commit_rev":
"1d4fa2ca68d3a08501dfe9131770f4e5dd622bf5"}

[commit-bot: I haz the power, 2017-02-08 23:04:44]

Description was changed from

==========
MD Settings: Move bluetooth UI from dialog to subpage

This CL does the following:
1. Moves the list of paired devices from the dialog the subpage.
2. Updates the top level bluetooth page to be two lines (with enabled state in
the second line) with a toggle switch (similar to Autofill settings or Manage
paswords).
3. Moves the spinner to be in the same row as the 'Unpaired devices' subtitle in
the subpage.

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Move bluetooth UI from dialog to subpage

This CL does the following:
1. Moves the list of paired devices from the dialog the subpage.
2. Updates the top level bluetooth page to be two lines (with enabled state in
the second line) with a toggle switch (similar to Autofill settings or Manage
paswords).
3. Moves the spinner to be in the same row as the 'Unpaired devices' subtitle in
the subpage.

BUG=673946
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2676103002
Cr-Commit-Position: refs/heads/master@{#449123}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d4fa2ca68d3a08501dfe9131770...
==========

[commit-bot: I haz the power, 2017-02-08 23:04:45]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1d4fa2ca68d3a08501dfe9131770...