[memory-infra] Add EstimateMemoryUsage() for deque and friends.

[memory-infra] Add EstimateMemoryUsage() for deque and friends.

This CL implements EstimateMemoryUsage() for std::deque, std::queue,
std::priority_queue and std::stack (because it's a container adapter
similar to std::queue).

BUG=669108
Review-Url: https://codereview.chromium.org/2676043002
Cr-Commit-Position: refs/heads/master@{#448156}
Committed: https://chromium.googlesource.com/chromium/src/+/3d7f2c60c1decab6a6dd8a1a4dfaf70d9a5e3e24

[DmitrySkiba, 2017-02-03 20:25:47]

dskiba@chromium.org changed reviewers:
+ primiano@chromium.org, xunjieli@chromium.org

[DmitrySkiba, 2017-02-03 20:25:47]

PTAL.

This is needed to unblock https://codereview.chromium.org/2665283003

[xunjieli, 2017-02-03 20:29:00]

This is great! Thanks a lot. I will defer the review to Primiano. 

Dmitry, is it safe to assume that this file is stable in the long run? (e.g. it
won't pull in new non-standard dependencies.) I would like to upstream this file
so we can use it to instrument shared Http2 and QUIC code.

[Primiano Tucci (use gerrit), 2017-02-03 20:31:25]

LGTM

On 2017/02/03 20:29:00, xunjieli wrote:
> This is great! Thanks a lot. I will defer the review to Primiano. 
> 
> Dmitry, is it safe to assume that this file is stable in the long run? (e.g.
it
> won't pull in new non-standard dependencies.) I would like to upstream this
file
> so we can use it to instrument shared Http2 and QUIC code.

Honestly I wouldn't bother pulling this in the internal code, and instead I
would create a simple templated function that returns always 0.

[xunjieli, 2017-02-03 20:32:14]

On 2017/02/03 20:31:25, Primiano Tucci wrote:
> LGTM
> 
> On 2017/02/03 20:29:00, xunjieli wrote:
> > This is great! Thanks a lot. I will defer the review to Primiano. 
> > 
> > Dmitry, is it safe to assume that this file is stable in the long run? (e.g.
> it
> > won't pull in new non-standard dependencies.) I would like to upstream this
> file
> > so we can use it to instrument shared Http2 and QUIC code.
> 
> Honestly I wouldn't bother pulling this in the internal code, and instead I
> would create a simple templated function that returns always 0.

Alright, I think that works too. Thanks.

[DmitrySkiba, 2017-02-03 20:42:32]

On 2017/02/03 20:29:00, xunjieli wrote:
> This is great! Thanks a lot. I will defer the review to Primiano. 
> 
> Dmitry, is it safe to assume that this file is stable in the long run? (e.g.
it
> won't pull in new non-standard dependencies.) I would like to upstream this
file
> so we can use it to instrument shared Http2 and QUIC code.

But it already has EMUs for base::StringPiece, and it depends on several base/
headers - is this OK?

I think we can refactor STL-specific bits into a separate header. We can even
open-source that header and then include it as third_party dependency (both in
Chrome and in net).

[DmitrySkiba, 2017-02-03 20:48:39]

The CQ bit was checked by dskiba@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 20:49:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 21:53:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 21:53:37]

Dry run: This issue passed the CQ dry run.

[DmitrySkiba, 2017-02-03 22:09:44]

The CQ bit was checked by dskiba@chromium.org

[commit-bot: I haz the power, 2017-02-03 22:10:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 06:33:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486159784677450, "parent_rev":
"607dee2dcb2f909fb33b2a31d0b3eef5baf3c2ae", "commit_rev":
"3d7f2c60c1decab6a6dd8a1a4dfaf70d9a5e3e24"}

[commit-bot: I haz the power, 2017-02-04 06:34:16]

Description was changed from

==========
[memory-infra] Add EstimateMemoryUsage() for deque and friends.

This CL implements EstimateMemoryUsage() for std::deque, std::queue,
std::priority_queue and std::stack (because it's a container adapter
similar to std::queue).

BUG=669108
==========

to

==========
[memory-infra] Add EstimateMemoryUsage() for deque and friends.

This CL implements EstimateMemoryUsage() for std::deque, std::queue,
std::priority_queue and std::stack (because it's a container adapter
similar to std::queue).

BUG=669108

Review-Url: https://codereview.chromium.org/2676043002
Cr-Commit-Position: refs/heads/master@{#448156}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d7f2c60c1decab6a6dd8a1a4dfa...
==========

[commit-bot: I haz the power, 2017-02-04 06:34:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d7f2c60c1decab6a6dd8a1a4dfa...