Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3875)

Unified Diff: ash/common/system/tray/tray_popup_utils.cc

Issue 2675983003: views::Separator cleanup. (Closed)
Patch Set: revert test change Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/system/tray/tray_details_view.cc ('k') | ash/common/system/user/user_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/tray/tray_popup_utils.cc
diff --git a/ash/common/system/tray/tray_popup_utils.cc b/ash/common/system/tray/tray_popup_utils.cc
index cc04e18754936e87b843fe393fb76cc577af4f76..b409a3ece4a200957e0cf8de438af6dcd9afd8a9 100644
--- a/ash/common/system/tray/tray_popup_utils.cc
+++ b/ash/common/system/tray/tray_popup_utils.cc
@@ -293,7 +293,7 @@ void TrayPopupUtils::ShowStickyHeaderSeparator(views::View* view,
if (show_separator) {
view->SetBorder(views::CreatePaddedBorder(
views::CreateSolidSidedBorder(0, 0, kSeparatorWidth, 0,
- kHorizontalSeparatorColor),
+ kMenuSeparatorColor),
gfx::Insets(kMenuSeparatorVerticalPadding, 0,
kMenuSeparatorVerticalPadding - kSeparatorWidth, 0)));
} else {
@@ -324,10 +324,9 @@ views::LabelButton* TrayPopupUtils::CreateTrayPopupButton(
}
views::Separator* TrayPopupUtils::CreateVerticalSeparator() {
- views::Separator* separator =
- new views::Separator(views::Separator::HORIZONTAL);
- separator->SetPreferredSize(kHorizontalSeparatorHeight);
- separator->SetColor(kHorizontalSeparatorColor);
+ views::Separator* separator = new views::Separator();
+ separator->SetPreferredHeight(24);
+ separator->SetColor(kMenuSeparatorColor);
return separator;
}
@@ -416,12 +415,10 @@ gfx::Rect TrayPopupUtils::GetInkDropBounds(TrayPopupInkDropStyle ink_drop_style,
}
views::Separator* TrayPopupUtils::CreateListItemSeparator(bool left_inset) {
- views::Separator* separator =
- new views::Separator(views::Separator::HORIZONTAL);
- separator->SetColor(kHorizontalSeparatorColor);
- separator->SetPreferredSize(kSeparatorWidth);
+ views::Separator* separator = new views::Separator();
+ separator->SetColor(kMenuSeparatorColor);
separator->SetBorder(views::CreateEmptyBorder(
- kMenuSeparatorVerticalPadding - kSeparatorWidth,
+ kMenuSeparatorVerticalPadding - views::Separator::kThickness,
left_inset
? kMenuExtraMarginFromLeftEdge + kMenuButtonSize +
kTrayPopupLabelHorizontalPadding
@@ -431,12 +428,10 @@ views::Separator* TrayPopupUtils::CreateListItemSeparator(bool left_inset) {
}
views::Separator* TrayPopupUtils::CreateListSubHeaderSeparator() {
- views::Separator* separator =
- new views::Separator(views::Separator::HORIZONTAL);
- separator->SetColor(kHorizontalSeparatorColor);
- separator->SetPreferredSize(kSeparatorWidth);
+ views::Separator* separator = new views::Separator();
+ separator->SetColor(kMenuSeparatorColor);
separator->SetBorder(views::CreateEmptyBorder(
- kMenuSeparatorVerticalPadding - kSeparatorWidth, 0, 0, 0));
+ kMenuSeparatorVerticalPadding - views::Separator::kThickness, 0, 0, 0));
return separator;
}
« no previous file with comments | « ash/common/system/tray/tray_details_view.cc ('k') | ash/common/system/user/user_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698