Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: ash/common/system/tray/tray_details_view.cc

Issue 2675983003: views::Separator cleanup. (Closed)
Patch Set: revert test change Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/system/tray/tray_constants.cc ('k') | ash/common/system/tray/tray_popup_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/tray/tray_details_view.cc
diff --git a/ash/common/system/tray/tray_details_view.cc b/ash/common/system/tray/tray_details_view.cc
index b51ab37e5e056c1aae9b36f7006ae5e2f3eefa81..e2570fe6d634d20fa60018e0a2481bfc219920a8 100644
--- a/ash/common/system/tray/tray_details_view.cc
+++ b/ash/common/system/tray/tray_details_view.cc
@@ -132,7 +132,6 @@ class ScrollContentsView : public views::View {
}
private:
- const SkColor kSeparatorColor = SkColorSetA(SK_ColorBLACK, 0x1F);
const int kShadowOffsetY = 2;
const int kShadowBlur = 2;
// TODO(fukino): Remove this constant once we stop maintaining pre-MD design.
@@ -218,7 +217,7 @@ class ScrollContentsView : public views::View {
cc::PaintFlags flags;
gfx::ShadowValues shadow;
shadow.emplace_back(gfx::Vector2d(0, kShadowOffsetY), kShadowBlur,
- kSeparatorColor);
+ kMenuSeparatorColor);
flags.setLooper(gfx::CreateShadowDrawLooperCorrectBlur(shadow));
flags.setAntiAlias(true);
canvas->ClipRect(shadowed_area, SkClipOp::kDifference);
@@ -342,12 +341,10 @@ void TrayDetailsView::CreateTitleRow(int string_id) {
tri_view_->SetBorder(views::CreateEmptyBorder(kTitleRowPaddingTop, 0,
kTitleRowPaddingBottom, 0));
AddChildViewAt(tri_view_, 0);
- views::Separator* separator =
- new views::Separator(views::Separator::HORIZONTAL);
- separator->SetColor(kHorizontalSeparatorColor);
- separator->SetPreferredSize(kSeparatorWidth);
+ views::Separator* separator = new views::Separator();
+ separator->SetColor(kMenuSeparatorColor);
separator->SetBorder(views::CreateEmptyBorder(
- kTitleRowProgressBarHeight - kSeparatorWidth, 0, 0, 0));
+ kTitleRowProgressBarHeight - views::Separator::kThickness, 0, 0, 0));
AddChildViewAt(separator, kTitleRowSeparatorIndex);
} else {
title_row_ = new SpecialPopupRow();
« no previous file with comments | « ash/common/system/tray/tray_constants.cc ('k') | ash/common/system/tray/tray_popup_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698