Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2675973002: Tweak apk_size_regressions.md to be more explicit about a couple things (Closed)

Created:
3 years, 10 months ago by agrieve
Modified:
3 years, 10 months ago
Reviewers:
tdresser
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak apk_size_regressions.md to be more explicit about a couple things 1. Say "Some regressions" rather than "Most regressions" at the top. 2. Point out that since bisects don't work, sheriffs are not to spend time finding culprit 3. Add instructions for what to change when filing bugs BUG=none Review-Url: https://codereview.chromium.org/2675973002 Cr-Commit-Position: refs/heads/master@{#448328} Committed: https://chromium.googlesource.com/chromium/src/+/6b10ff77d359100c6fd3e287feccd0342211b51d

Patch Set 1 #

Total comments: 2

Patch Set 2 : add bug link for template #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M tools/perf/docs/apk_size_regressions.md View 1 3 chunks +8 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
agrieve
Some tweaks based on your feedback :)
3 years, 10 months ago (2017-02-03 16:52:13 UTC) #3
tdresser
LGTM % question. https://codereview.chromium.org/2675973002/diff/1/tools/perf/docs/apk_size_regressions.md File tools/perf/docs/apk_size_regressions.md (right): https://codereview.chromium.org/2675973002/diff/1/tools/perf/docs/apk_size_regressions.md#newcode43 tools/perf/docs/apk_size_regressions.md:43: * Remove label: `Restrict-View-Google` Why do ...
3 years, 10 months ago (2017-02-06 15:44:08 UTC) #6
agrieve
https://codereview.chromium.org/2675973002/diff/1/tools/perf/docs/apk_size_regressions.md File tools/perf/docs/apk_size_regressions.md (right): https://codereview.chromium.org/2675973002/diff/1/tools/perf/docs/apk_size_regressions.md#newcode43 tools/perf/docs/apk_size_regressions.md:43: * Remove label: `Restrict-View-Google` On 2017/02/06 15:44:07, tdresser wrote: ...
3 years, 10 months ago (2017-02-06 16:35:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675973002/20001
3 years, 10 months ago (2017-02-06 16:36:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/359123)
3 years, 10 months ago (2017-02-06 17:39:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675973002/20001
3 years, 10 months ago (2017-02-06 18:07:26 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 18:50:56 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6b10ff77d359100c6fd3e287fecc...

Powered by Google App Engine
This is Rietveld 408576698