|
|
Chromium Code Reviews
DescriptionDisables MTPDeviceDelegateImplWinTest.GalleryNameMTP
BUG=686803
TBR=reillyg@
Review-Url: https://codereview.chromium.org/2675963003
Cr-Commit-Position: refs/heads/master@{#448013}
Committed: https://chromium.googlesource.com/chromium/src/+/a80d18c3fa89a2cc0b7c01a22a6aa1df796f550d
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by mahmadi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/02/03 16:29:38, moe wrote: > The CQ bit was checked by mailto:mahmadi@chromium.org https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2... [ RUN ] MTPDeviceDelegateImplWinTest.GalleryNameMTP [2976:4440:0203/080040.171:10134105:FATAL:media_file_system_registry.cc(765)] Check failed: StorageMonitor::GetInstance(). Backtrace: base::debug::StackTrace::StackTrace [0x0C2F45A7+55] base::debug::StackTrace::StackTrace [0x0C2F4181+17] logging::LogMessage::~LogMessage [0x0C34061B+59] MediaFileSystemRegistry::~MediaFileSystemRegistry [0x0466838B+139] MediaFileSystemRegistry::`scalar deleting destructor' [0x0466BA8F+15] std::default_delete<MediaFileSystemRegistry>::operator() [0x03B3B7EA+42] std::unique_ptr<MediaFileSystemRegistry,std::default_delete<MediaFileSystemRegistry> >::~unique_ptr<MediaFileSystemRegistry,std::default_delete<MediaFileSystemRegistry> > [0x03B3B02B+43] TestingBrowserProcess::~TestingBrowserProcess [0x03B3B2B6+374] TestingBrowserProcess::`scalar deleting destructor' [0x03B3B99F+15] TestingBrowserProcess::DeleteInstance [0x03B3BB58+56] testing::EmptyTestEventListener::OnTestCaseStart [0x03B47BD9+201] testing::internal::TestEventRepeater::OnTestEnd [0x03D46F9B+91] testing::TestInfo::Run [0x03D4ABB4+260] testing::TestCase::Run [0x03D4A9FF+191] testing::internal::UnitTestImpl::RunAllTests [0x03D4AFE5+661] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x03D32424+52] testing::UnitTest::Run [0x03D4ACDF+207] RUN_ALL_TESTS [0x03B62D4F+15] base::TestSuite::Run [0x03B62E83+115] content::UnitTestTestSuite::Run [0x080FC3C6+22] ??$Invoke@PAVUnitTestTestSuite@content@@$$V@?$FunctorTraits@P8UnitTestTestSuite@content@@AEHXZX@internal@base@@SAHP8UnitTestTestSuite@content@@AEHXZ$$QAPAV34@@Z [0x080E9A12+18] base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::UnitTestTestSuite::*const &)(void),content::UnitTestTestSuite *> [0x080E9A74+36] base::internal::Invoker<base::internal::BindState<int (__thiscall content::UnitTestTestSuite::*)(void),base::internal::UnretainedWrapper<content::UnitTestTestSuite> >,int __cdecl(void)>::RunImpl<int (__thiscall content::UnitTestTestSuite::*const &)(void), [0x080E9ACB+59] base::internal::Invoker<base::internal::BindState<int (__thiscall content::UnitTestTestSuite::*)(void),base::internal::UnretainedWrapper<content::UnitTestTestSuite> >,int __cdecl(void)>::Run [0x080E9C94+36] base::internal::RunMixin<base::Callback<int __cdecl(void),1,1> >::Run [0x02BEE36F+63] base::LaunchUnitTests [0x03B6CB3B+411] base::LaunchUnitTests [0x03B6C971+81] main [0x080E9DC9+233] invoke_main [0x080E7E6E+30] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:64) __scrt_common_main_seh [0x080E7CF0+336] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253) __scrt_common_main [0x080E7B8D+13] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:296) mainCRTStartup [0x080E7E88+8] (f:\ddctools\crtcstartup\src\startup\exe_main.cpp:17) BaseThreadInitThunk [0x75E5337A+18] RtlInitializeExceptionChain [0x77DE9882+99] RtlInitializeExceptionChain [0x77DE9855+54]
mahmadi@chromium.org changed reviewers: + joedow@chromium.org
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Description was changed from ========== Disables MTPDeviceDelegateImplWinTest.GalleryNameMTP BUG=686803 ========== to ========== Disables MTPDeviceDelegateImplWinTest.GalleryNameMTP BUG=686803 TBR=reillyg@ ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mahmadi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486141165935300, "parent_rev":
"4cb58b4a871a66255e0cc5412ce250db54c74e07", "commit_rev":
"a80d18c3fa89a2cc0b7c01a22a6aa1df796f550d"}
Message was sent while issue was closed.
Description was changed from ========== Disables MTPDeviceDelegateImplWinTest.GalleryNameMTP BUG=686803 TBR=reillyg@ ========== to ========== Disables MTPDeviceDelegateImplWinTest.GalleryNameMTP BUG=686803 TBR=reillyg@ Review-Url: https://codereview.chromium.org/2675963003 Cr-Commit-Position: refs/heads/master@{#448013} Committed: https://chromium.googlesource.com/chromium/src/+/a80d18c3fa89a2cc0b7c01a22a6a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a80d18c3fa89a2cc0b7c01a22a6a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
