Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: ui/views/controls/menu/menu_message_loop_mac.cc

Issue 267593005: Refactor menu controller to isolate aura dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removing ifdefs, work in progress Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/menu/menu_message_loop_mac.cc
diff --git a/ui/views/controls/menu/menu_message_loop_mac.cc b/ui/views/controls/menu/menu_message_loop_mac.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1d987d5bdfb7a8604af1fbd2723b0c758fe96041
--- /dev/null
+++ b/ui/views/controls/menu/menu_message_loop_mac.cc
@@ -0,0 +1,28 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
tapted 2014/05/04 23:43:39 nit: no c
Andre 2014/05/05 22:41:29 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/run_loop.h"
+#include "ui/views/controls/menu/menu_message_loop.h"
tapted 2014/05/04 23:43:39 nit: first include
Andre 2014/05/05 22:41:29 Done.
+
+namespace views {
+
+void MenuMessageLoop::RepostEvent(const ui::LocatedEvent& event) {
+}
tapted 2014/05/04 23:43:39 should have a NOTIMPLEMENTED()?
Andre 2014/05/05 22:41:29 Done.
+
+void MenuMessageLoop::Run(MenuController* controller, bool nested_menu) {
+ base::MessageLoopForUI* loop = base::MessageLoopForUI::current();
tapted 2014/05/04 23:43:39 nit: should #include base/message_loop/message_loo
Andre 2014/05/05 22:41:29 Done.
+ base::MessageLoop::ScopedNestableTaskAllower allow(loop);
+ base::RunLoop run_loop;
+ run_loop.Run();
+}
+
+bool MenuMessageLoop::ShouldQuitNow() const {
+ return true;
+}
+
+void MenuMessageLoop::QuitNow() {
+ base::MessageLoop::current()->QuitNow();
+}
+
+} // namespace views

Powered by Google App Engine
This is Rietveld 408576698