Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Side by Side Diff: ui/views/controls/menu/menu_message_loop_mac.cc

Issue 267593005: Refactor menu controller to isolate aura dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removing ifdefs, work in progress Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
tapted 2014/05/04 23:43:39 nit: no c
Andre 2014/05/05 22:41:29 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/run_loop.h"
6 #include "ui/views/controls/menu/menu_message_loop.h"
tapted 2014/05/04 23:43:39 nit: first include
Andre 2014/05/05 22:41:29 Done.
7
8 namespace views {
9
10 void MenuMessageLoop::RepostEvent(const ui::LocatedEvent& event) {
11 }
tapted 2014/05/04 23:43:39 should have a NOTIMPLEMENTED()?
Andre 2014/05/05 22:41:29 Done.
12
13 void MenuMessageLoop::Run(MenuController* controller, bool nested_menu) {
14 base::MessageLoopForUI* loop = base::MessageLoopForUI::current();
tapted 2014/05/04 23:43:39 nit: should #include base/message_loop/message_loo
Andre 2014/05/05 22:41:29 Done.
15 base::MessageLoop::ScopedNestableTaskAllower allow(loop);
16 base::RunLoop run_loop;
17 run_loop.Run();
18 }
19
20 bool MenuMessageLoop::ShouldQuitNow() const {
21 return true;
22 }
23
24 void MenuMessageLoop::QuitNow() {
25 base::MessageLoop::current()->QuitNow();
26 }
27
28 } // namespace views
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698