Fix flaky compositing/reflections/nested-reflection-transition.html

Fix flaky compositing/reflections/nested-reflection-transition.html

We now wait for the compositor before completing the test and
capturing pixels.


BUG=674396, 674468
Review-Url: https://codereview.chromium.org/2675913003
Cr-Commit-Position: refs/heads/master@{#451993}
Committed: https://chromium.googlesource.com/chromium/src/+/cd543f8a4f13cc05b0c4f9dbf8f1497a8b6b5845

[Eric Willigers, 2017-02-03 23:18:12]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 23:18:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-02-03 23:18:39]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[Eric Willigers, 2017-02-04 00:51:22]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 00:52:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 00:54:19]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eric Willigers, 2017-02-06 01:06:17]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 01:06:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 02:34:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 02:34:28]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-02-20 02:39:19]

lgtm

[Eric Willigers, 2017-02-20 02:53:11]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-02-20 02:53:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 03:51:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 03:51:49]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:142
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
77f11f0d222531d401b5991152da9d60a4f9bff8..2e664e655eacff4fc8da7041a5ab657f6a34d20c
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -142,11 +142,7 @@ crbug.com/664852
virtual/gpu/fast/canvas/canvas-lose-restore-googol-size.html [
 crbug.com/664852 virtual/gpu/fast/canvas/canvas-lost-gpu-context.html [ Pass
Failure ]
 crbug.com/664852 virtual/gpu/fast/canvas/OffscreenCanvas-2d-drawImage.html [
Pass Failure ]
 
-# Added 2016-12-14
-crbug.com/674396 [ Win ]
compositing/reflections/nested-reflection-transition.html [ Pass Failure ]
-
-# Added 2016-12-15
-crbug.com/674468 [ Trusty ]
compositing/reflections/nested-reflection-transition.html [ Pass Failure ]
+crbug.com/674396 compositing/reflections/nested-reflection-transition.html [
NeedsRebaseline ]
 
 
 # ====== LayoutNG-only failures from here ======

[Eric Willigers, 2017-02-20 23:23:21]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-02-20 23:23:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2675913003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-20 23:23:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 00:30:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 00:30:37]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:135
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
f4f1d11079dd84b9be48484793896a3ef90ed88a..cec7ea30a6c215db07a2b43e59003da0ab06841a
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -135,11 +135,7 @@ crbug.com/664852
virtual/gpu/fast/canvas/canvas-lose-restore-googol-size.html [
 crbug.com/664852 virtual/gpu/fast/canvas/canvas-lost-gpu-context.html [ Pass
Failure ]
 crbug.com/664852 virtual/gpu/fast/canvas/OffscreenCanvas-2d-drawImage.html [
Pass Failure ]
 
-# Added 2016-12-14
-crbug.com/674396 [ Win ]
compositing/reflections/nested-reflection-transition.html [ Pass Failure ]
-
-# Added 2016-12-15
-crbug.com/674468 [ Trusty ]
compositing/reflections/nested-reflection-transition.html [ Pass Failure ]
+crbug.com/674396 compositing/reflections/nested-reflection-transition.html [
NeedsRebaseline ]
 
 # Added 2017-01-16
 crbug.com/681471 paint/invalidation/media-audio-no-spurious-repaints.html [
Failure Pass Timeout ]

[Eric Willigers, 2017-02-22 00:21:57]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-02-22 00:21:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2675913003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-22 00:22:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 02:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:26:04]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Eric Willigers, 2017-02-22 10:14:23]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-02-22 10:14:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 11:15:13]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487758463091150,
"parent_rev": "eff357ef3a21515a5bfaa487b687d7d7353024f2", "commit_rev":
"cd543f8a4f13cc05b0c4f9dbf8f1497a8b6b5845"}

[commit-bot: I haz the power, 2017-02-22 11:16:20]

Description was changed from

==========
Fix flaky compositing/reflections/nested-reflection-transition.html

We now wait for the compositor before completing the test and
capturing pixels.


BUG=674396,674468
==========

to

==========
Fix flaky compositing/reflections/nested-reflection-transition.html

We now wait for the compositor before completing the test and
capturing pixels.


BUG=674396,674468

Review-Url: https://codereview.chromium.org/2675913003
Cr-Commit-Position: refs/heads/master@{#451993}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd543f8a4f13cc05b0c4f9dbf8f1...
==========

[commit-bot: I haz the power, 2017-02-22 11:16:21]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/cd543f8a4f13cc05b0c4f9dbf8f1...