Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2675863003: MD Settings: Fix quick_unlock_authenticate tests in Vulcanized mode. (Closed)

Created:
3 years, 10 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
stevenjb
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, Dan Beam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix quick_unlock_authenticate tests in Vulcanized mode. The test shouldn't explicitly import load_time_data.js, because in Vulcanized mode it ends up importing that file twice, whcih throws an error. Instead the element being tested should depend on i18n_setup.html in the first place. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2675863003 Cr-Commit-Position: refs/heads/master@{#448044} Committed: https://chromium.googlesource.com/chromium/src/+/505d7a79e8ee2d03d1abcfa14c0bfe64caa6b627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/resources/settings/people_page/setup_pin_dialog.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
dpapad
3 years, 10 months ago (2017-02-03 18:18:04 UTC) #8
stevenjb
lgtm
3 years, 10 months ago (2017-02-03 18:42:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675863003/1
3 years, 10 months ago (2017-02-03 18:45:13 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 19:28:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/505d7a79e8ee2d03d1abcfa14c0b...

Powered by Google App Engine
This is Rietveld 408576698