Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2675833002: DevTools: simplify TimelineOverview interface, move windowTimes()/windowBoundaries() to pane (Closed)

Created:
3 years, 10 months ago by caseq
Modified:
3 years, 10 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: simplify TimelineOverview interface, move windowTimes()/windowBoundaries() to pane Review-Url: https://codereview.chromium.org/2675833002 Cr-Commit-Position: refs/heads/master@{#447946} Committed: https://chromium.googlesource.com/chromium/src/+/19510aab05edeae86a993fcc27a08f39b4824c1d

Patch Set 1 #

Patch Set 2 : also always assume leftPadding to be 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -84 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-window-filter.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js View 1 9 chunks +20 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
caseq
3 years, 10 months ago (2017-02-02 21:59:39 UTC) #2
alph
lgtm
3 years, 10 months ago (2017-02-03 00:42:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675833002/20001
3 years, 10 months ago (2017-02-03 00:43:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/111884)
3 years, 10 months ago (2017-02-03 02:08:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675833002/20001
3 years, 10 months ago (2017-02-03 02:14:36 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:58:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/19510aab05edeae86a993fcc27a0...

Powered by Google App Engine
This is Rietveld 408576698