Chromium Code Reviews Chromium Code Reviews
Issue 2675823002:
Convert DelayNode tests to testharness (Closed)
| Index: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html |
| diff --git a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html |
| index 13f9b97d2992d1d776c52b0f4d231a88cbceba30..8fda54f0be68109b54310290afd1ec3cbb065d68 100644 |
| --- a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html |
| +++ b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html |
| @@ -2,28 +2,20 @@ |
| <html> |
| <head> |
| -<script src="../../resources/js-test.js"></script> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| <script src="../resources/audit-util.js"></script> |
| -<script src="../resources/audio-testing.js"></script> |
| +<script src="../resources/audit.js"></script> |
| <script src="../resources/delay-testing.js"></script> |
| </head> |
| <body> |
| - |
| -<div id="description"></div> |
| -<div id="console"></div> |
| - |
| <script> |
| -description("Tests DelayNode with delay set to non-default maximum delay."); |
| +let audit = Audit.createTaskRunner(); |
| + |
| +audit.define("test", function (task, should) { |
| + task.describe("DelayNode with delay set to non-default maximum delay"); |
| -function runTest() { |
| - if (window.testRunner) { |
| - testRunner.dumpAsText(); |
| - testRunner.waitUntilDone(); |
| - } |
| - |
| - window.jsTestIsAsync = true; |
| - |
| // Create offline audio context. |
| var context = new OfflineAudioContext(1, sampleRate * renderLengthSeconds, sampleRate); |
| var toneBuffer = createToneBuffer(context, 20, 20 * toneLengthSeconds, sampleRate); // 20Hz tone |
| @@ -40,12 +32,12 @@ function runTest() { |
| delay.connect(context.destination); |
| bufferSource.start(0); |
| - context.oncomplete = checkDelayedResult(toneBuffer); |
| - context.startRendering(); |
| -} |
| - |
| -runTest(); |
| + context.startRendering() |
| + .then(buffer => checkDelayedResult(buffer, toneBuffer, should)) |
| + .then(task.done.bind(task));; |
|
hongchan
2017/02/06 17:20:27
ditto.
Raymond Toy
2017/02/06 18:41:36
Done.
|
| +}); |
| +audit.run(); |
| </script> |
| </body> |
