third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html - Issue 2675823002: Convert DelayNode tests to testharness

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html

Issue 2675823002: Convert DelayNode tests to testharness (Closed)

Patch Set: Remove commented-out code. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay-expected.txt » ('j') | third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html

index c0589ee87f9b224e8f7c1bc17b2a62f1ac15550b..9614a44fecca00552388c8290e5f16fa9fe8b118 100644

--- a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html

+++ b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html

@@ -2,28 +2,20 @@

<html>

<head>

-<script src="../../resources/js-test.js"></script>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

-<script src="../resources/audio-testing.js"></script>

+<script src="../resources/audit.js"></script>

</head>

<body>

-<div id="description"></div>

-<div id="console"></div>

-description("Tests DelayNode with delay set to default maximum delay.");

+let audit = Audit.createTaskRunner();

+audit.define("test", function (task, should) {

+ task.describe("DelayNode with delay set to default maximum delay");

-function runTest() {

- if (window.testRunner) {

- testRunner.dumpAsText();

- testRunner.waitUntilDone();

- }

- window.jsTestIsAsync = true;

// Create offline audio context.

var context = new OfflineAudioContext(1, sampleRate * renderLengthSeconds, sampleRate);

var toneBuffer = createToneBuffer(context, 20, 20 * toneLengthSeconds, sampleRate); // 20Hz tone

@@ -39,11 +31,12 @@ function runTest() {

delay.connect(context.destination);

bufferSource.start(0);

- context.oncomplete = checkDelayedResult(toneBuffer);

- context.startRendering();

+ context.startRendering()

+ .then(buffer => checkDelayedResult(buffer, toneBuffer, should))

+ .then(task.done.bind(task));

hongchan 2017/02/06 17:20:27 task => task.done() This might be more readable.

Raymond Toy 2017/02/06 18:41:36 Done.

+});

-runTest();

+audit.run();

</script>