Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: chrome/browser/android/webapk/webapk_installer.cc

Issue 2675803004: Fall back to shortcut A2HS when Phonesky is out of date or unavailable. (Closed)
Patch Set: Update add_to_homescreen_data_fetcher_unittest.cc. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.cc
diff --git a/chrome/browser/android/webapk/webapk_installer.cc b/chrome/browser/android/webapk/webapk_installer.cc
index 161a3881865f2dd5aa258762a891f35d4ba10ac9..e92ebb7c1d6329ad857bf0beb7e5a74a9ab80913 100644
--- a/chrome/browser/android/webapk/webapk_installer.cc
+++ b/chrome/browser/android/webapk/webapk_installer.cc
@@ -427,10 +427,8 @@ void WebApkInstaller::OnURLFetchComplete(const net::URLFetcher* source) {
if (CanUseGooglePlayInstallService()) {
int version = 1;
base::StringToInt(response->version(), &version);
- if (!InstallOrUpdateWebApkFromGooglePlay(
- response->package_name(), version, response->token())) {
- OnFailure();
- }
+ InstallOrUpdateWebApkFromGooglePlay(
+ response->package_name(), version, response->token());
pkotwicz 2017/02/03 18:56:32 Why this change? If we are ignoring the return val
Xi Han 2017/02/03 22:16:21 This is because ChromeWebApkHost::CanUseGooglePlay
pkotwicz 2017/02/03 23:05:05 Please file the bug too :)
return;
}

Powered by Google App Engine
This is Rietveld 408576698